-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
southpark.de extractor broke due to the site structure changing, using the ComedyCentral extractor should work. #26763
Comments
I am seeing the same thing when trying to grab episodes from southpark.cc.com. Seems like the MTV extractor is being used instead of the ComedyCentral one.
|
southpark.cc.com changed their whole URL structure about 2 weeks ago. For example: |
It's not as simple as changing the |
Their websites are strictly divided by geolocation. I get redirected to southpark.de due to me being in germany. It even detects my location trough tor (geolocation trough javascript time?). |
Similar issue with MTV.com they must have changed them across the board. |
I fudged the diff --git a/youtube_dl/extractor/comedycentral.py b/youtube_dl/extractor/comedycentral.py
index d08b909a6..b1d175759 100644
--- a/youtube_dl/extractor/comedycentral.py
+++ b/youtube_dl/extractor/comedycentral.py
@@ -45,14 +45,15 @@ class ComedyCentralFullEpisodesIE(MTVServicesInfoExtractor):
'only_matching': True,
}]
+ @classmethod
+ def suitable(cls, url):
+ return True
+
def _real_extract(self, url):
- playlist_id = self._match_id(url)
- webpage = self._download_webpage(url, playlist_id)
- mgid = self._extract_triforce_mgid(webpage, data_zone='t2_lc_promo1')
+ mgid = 'mgid:arc:episode:southparkstudios.com:230a4f02-f583-11ea-834d-70df2f866ace'
videos_info = self._get_videos_info(mgid)
return videos_info
-
class ToshIE(MTVServicesInfoExtractor):
IE_DESC = 'Tosh.0'
_VALID_URL = r'^https?://tosh\.cc\.com/video-(?:clips|collections)/[^/]+/(?P<videotitle>[^/?#]+)'
|
I applied the patch and can confirm that it works! I downloaded the Pandemic Special with no problem. |
Above Issue mentions that this has been fully fixed in youtube-dlc. |
I tested it, and downloading Southpark content does not work in Yotube-dlc yet. They have only implemented a fix for mtv. But as said it should be trivial to fix Southpark aswell. |
This has been fixed in youtube-dlc with blackjack4494#188 |
With the latest ComedyCentral / MTV fixes it looks like we're closer but still not there for South Park: [debug] System config: [] |
* https://github.com/ytdl-org/youtube-dl: [applepodcasts] fix extraction(closes ytdl-org#28445) [rtve] improve extraction release 2021.03.14 [ChangeLog] Actualize [ci skip] [southpark] Fix extraction and add support for southparkstudios.com (closes ytdl-org#26763, closes ytdl-org#28413)
Still getting |
Checklist
Verbose log
Description
Southpark.de has recently changed its site, breaking the southpark.de extractor. The first command was ran with the old url format which the southpark.de extractor works with, however it fails due to the old url redirecting to the new one. Below the first command is a second command with the new southpark.de url format, which fails due to no extractor being implemented for it.
I observed that the new southpark.de website looks and works similar to cc.com. Using the ComedyCentral extractor for southpark.de should probably work, I have not been able to test it out due to there being no way to force the use of an extractor for an unknown url.
Hope this will be fixed.
Thank you.
The text was updated successfully, but these errors were encountered: