Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery Upgrade #215

Closed
danpoltawski opened this issue Sep 23, 2020 · 11 comments · Fixed by #263
Closed

jQuery Upgrade #215

danpoltawski opened this issue Sep 23, 2020 · 11 comments · Fixed by #263
Assignees
Labels
pending_PR Waiting for a PR to be merged into master security Security issue
Milestone

Comments

@danpoltawski
Copy link

According to https://www.cvedetails.com/vulnerability-list/vendor_id-6538/product_id-11031/version_id-286384/Jquery-Jquery-2.1.1.html jQuery 2.1.1 has two CVE's against it and the the bundled jquery comes up in automated vulnerability scanning.

It would be good if this could be upgraded

@danpoltawski
Copy link
Author

I started hacking together a patch for this

master...TNP-Ltd:wip-jquery-upgrade

@github-actions github-actions bot added the Stale label May 18, 2024
@T185
Copy link

T185 commented May 23, 2024

Hi Everyone,

i just found this Issue and the solution for this.

@danpoltawski can you push this solution to the main branch and try to merge it against the main repo?

We are also see this CVE in our environment and i think a 10 years old library can be updated ;)

Thank you so much in advance and have a great day!

@danpoltawski
Copy link
Author

@T185 I can't - I'm not a maintainer of this repo, but if a maintainer suggests interest in merging the I will rebase/update it

@robertcheramy robertcheramy self-assigned this May 23, 2024
@robertcheramy robertcheramy added security Security issue and removed Stale labels May 23, 2024
@robertcheramy robertcheramy added this to the 0.14.0 milestone May 23, 2024
@robertcheramy
Copy link
Collaborator

I'll be happy to merge a Pull Request which resolves this issue.

@robertcheramy
Copy link
Collaborator

I'd like a better way to do this - I'm trying to solve this with gems, so don't loose time rebasing your modification.

@danpoltawski
Copy link
Author

I'd like a better way to do this - I'm trying to solve this with gems, so don't loose time rebasing your modification.

Thanks - I'm going to be away for the next two weeks, so I'll come back to this the and hope you've managed to solve it that way in the meantime

@T185
Copy link

T185 commented May 23, 2024

Wow, thank you very much for your help and effort ! I would like to hear from you and if i can help, pls ping me :)

@robertcheramy
Copy link
Collaborator

I've found a way to do this (install the libs with npm, copy them with rake in our public folder), but I first have to repair other broken things first (dependency update but also older changes in the repository) - if I change to much at a time, it will be difficult to repair things.

@robertcheramy
Copy link
Collaborator

Update:

  • haml ist fixed (and merged into master)
  • I've already migrated Bootstrap and jQuery to the latest versions (and moved to the standard bootstrap design)
  • I'm still working on (understanding) datatables
  • I'm unsure the RANCID Migration-tool is still needed by someone out there. It will be difficult for me to test if it stills works.

I'll make a PR as soon as I've got something that is presentable.

@robertcheramy
Copy link
Collaborator

If you want to try out, this is the working branch: https://github.com/robertcheramy/oxidized-web/tree/update-weblibs

This is still work in progress:

  • add a Documentation how to run from git
  • diffs have to be polished
  • the migration tool has not been migrated yet

@robertcheramy
Copy link
Collaborator

This issue will be fixed with PR #263. Have a look at it, I will let the PR open a few day before merging into master.

@robertcheramy robertcheramy added the pending_PR Waiting for a PR to be merged into master label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending_PR Waiting for a PR to be merged into master security Security issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants