Update weblibs, dependencies & webui #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Run npm install / update to install / update the dependend weblibs - Run rake weblib to update them in the project - Dependencies should be tracked by dependabot
- Switched to Bootstrap 5 - Switched to Datatables.net 2 - Latest jQuery - Simplified CSS / stick as much as possible to bootstrap - Removed sass & dependency (not supported anymore, an this can be done in CSS). Custom CSS went into /css/oxidized.css. Closes: ytti#253 - Use Bootstrap Icons - Moved all links to javascripts into the header - Fixed Haml 6 not supporting escape_once anymore
- Our first minitest: get / redirects to /nodes - As a side effect, rake's default task runs rubocop AND minitest - Fixed rubocop warnings from last comits - I'm going for the normal (not minified) weblibs. We can still change this it performance problems are encountered - Ruby 3.0 is end of support as of https://www.ruby-lang.org/en/downloads/branches/ so we do not need to support it anymore. Added support for Ruby 3.3 in git workflows. - I'm not used to ruby 3.1 hash value shorthand syntax, so I let rubocup allow 3.0 and 3.1 style (EnforcedShorthandSyntax: either)
- instructions how to run from git - changelog for previous commits
- Site icon (/favicon.ico) also works when no html is loaded - consistent icon for page refresh: bi-arrow-clockwise - consistent icon for updating content: bi-repeat - replaced dif_15x17.png with icon bi-file-earmark-diff - removed CSS node_title, used <b> instead - fixed background-color for diffs - updated conf_search to new bootstrap design
The migration tool is needed once, and should not be part of the web frontend if no one maintains it. I also think there is no need for such a tool anymore - oxidized has been around for a few years now. The RANCID migration page will still be present in this major release, but will be removed in a future major release if noone opens and issue and steps forward to maintain it.
Not documented in CHANGELOG.md as it is already documented that the weblibs were updates.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
Update Weblibs
The weblibs (jQuery, bootstrap, datatables.net) were updated - Closes #215
They can be updated with npm update and rake weblibs. See docs/development.md
RANCID migration page
The RANCID migration page is deprecated and will be removed in a future major release
The migration tool is needed once, and should not be part of the web frontend if no one maintains it.
I also think there is no need for such a tool anymore - oxidized has been around for a few years now.
The RANCID migration page will still be present in this major release, but will be removed in a future major release if no one opens and issue and steps forward to maintain it.
More changes in one line