Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cambium ePMP Support #2195

Merged
6 commits merged into from
Jan 26, 2022
Merged

Cambium ePMP Support #2195

6 commits merged into from
Jan 26, 2022

Conversation

martydingo
Copy link
Contributor

Description

Pull Request for Cambium ePMP devices to add support for these devices. The model name to use is cambiumepmp

I've had this running on our Oxidized instance and it's working well and perfectly stable for the last three months.

This will close off #2000 with people reporting that it works great in that issue.

This will close off this issue also. #2081

@martydingo martydingo changed the title Create cambiumepmp.rb Cambium ePMP Support Oct 2, 2020
Fixed whitespace found on line 11
Fixed another whitespace..
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2020

Codecov Report

Merging #2195 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2195   +/-   ##
=======================================
  Coverage   63.32%   63.32%           
=======================================
  Files          30       30           
  Lines        1497     1497           
=======================================
  Hits          948      948           
  Misses        549      549           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be01808...c2c7136. Read the comment docs.

@martydingo
Copy link
Contributor Author

Had some trailing whitespaces, probably added by my code documentation tool..

All sorted now.

@wk
Copy link
Contributor

wk commented Oct 6, 2020

Hi there!

This looks great! It could use just a bit more documentation so that users can find it as part of the PR:

  • A mention in CHANGELOG.md taking credit for the new model
  • An addition to docs/Supported-OS-Types.md mentioning the relevant model and OS type

@martydingo
Copy link
Contributor Author

@wk Thanks very much, I've added some more documentation in, let me know if there's anything else required.

@martydingo
Copy link
Contributor Author

I'm sure the codecov doesn't apply for this situation?

@djh00t
Copy link

djh00t commented Jan 5, 2021

Hi Guys - any movement on this PR?

@martydingo
Copy link
Contributor Author

@djh00t No, still waiting for someone to come along and accept the PR.

@ghost
Copy link

ghost commented Dec 29, 2021

Please fix the conflict

@martydingo
Copy link
Contributor Author

Please fix the conflict

You want me to fix the conflict created by this PR being outstanding for over 12 months and therefore the changelog is conflicted?

I fixed this once and this has reoccured, is this going to be merged following this fix?

@ghost
Copy link

ghost commented Dec 30, 2021

will merge then

@ghost ghost mentioned this pull request Jan 12, 2022
@martydingo
Copy link
Contributor Author

@mortzu The CHANGELOG has been updated

@martydingo
Copy link
Contributor Author

lib/oxidized/model/model.rb:196:25: W: Lint/UnusedBlockArgument: Unused block argument - line. You can omit the argument if you don't care about it.

Is the error, which this PR does not touch. Please merge or reply with any outstanding actions required before the conflict reoccurs.

Thanks

@ghost ghost merged commit 291c75d into ytti:master Jan 26, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants