-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cambium ePMP Support #2195
Cambium ePMP Support #2195
Conversation
Fixed whitespace found on line 11
Fixed another whitespace..
Codecov Report
@@ Coverage Diff @@
## master #2195 +/- ##
=======================================
Coverage 63.32% 63.32%
=======================================
Files 30 30
Lines 1497 1497
=======================================
Hits 948 948
Misses 549 549 Continue to review full report at Codecov.
|
Had some trailing whitespaces, probably added by my code documentation tool.. All sorted now. |
Hi there! This looks great! It could use just a bit more documentation so that users can find it as part of the PR:
|
@wk Thanks very much, I've added some more documentation in, let me know if there's anything else required. |
I'm sure the codecov doesn't apply for this situation? |
Hi Guys - any movement on this PR? |
@djh00t No, still waiting for someone to come along and accept the PR. |
Please fix the conflict |
You want me to fix the conflict created by this PR being outstanding for over 12 months and therefore the changelog is conflicted? I fixed this once and this has reoccured, is this going to be merged following this fix? |
will merge then |
@mortzu The |
Is the error, which this PR does not touch. Please merge or reply with any outstanding actions required before the conflict reoccurs. Thanks |
Description
Pull Request for Cambium ePMP devices to add support for these devices. The model name to use is cambiumepmp
I've had this running on our Oxidized instance and it's working well and perfectly stable for the last three months.
This will close off #2000 with people reporting that it works great in that issue.
This will close off this issue also. #2081