3437 clean up login logout code for powerconnect.rb #3438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added model for Unifi / AirOS APs and some Unifi switches
…ng for a prompt and which ones
are not, (sends). I looked for documentation on post_login, and pre_logout but didn't find anything.
Also, I'm pretty sure the cli logout command needs to come after the last exit, not before. So I switched the
order there, and added a little delay just for good luck. Lastly I added a comment on filtering out a
timeout.
Clif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it more clear (at least to me ;-) which commands are waiting for a prompt and which ones are not, (sends). I looked for documentation on post_login, and pre_logout but didn't find anything.
Also, I'm pretty sure the cli logout command needs to come after the last exit, not before. So I switched the order there, and added a little delay just for good luck. Lastly I added a comment on filtering out a timeout.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
Re: #3437