Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to add public variables #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 25 additions & 8 deletions src/code_generation/cpp/cpp_class.py
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,11 @@ def __init__(self, **properties):
# aggregated classes
self.internal_class_elements = []

# class members
self.internal_variable_elements = []
# private class variables
self.internal_private_variable_elements = []

# public class variables
self.internal_public_variable_elements = []

# array class members
self.internal_array_elements = []
Expand Down Expand Up @@ -352,13 +355,16 @@ def add_enum(self, enum):
enum.ref_to_parent = self
self.internal_enum_elements.append(enum)

def add_variable(self, cpp_variable):
def add_variable(self, cpp_variable, is_private=True):
"""
@param: cpp_variable CppVariable instance
"""
cpp_variable.ref_to_parent = self
cpp_variable.is_class_member = True
self.internal_variable_elements.append(cpp_variable)
if is_private:
self.internal_private_variable_elements.append(cpp_variable)
else:
self.internal_public_variable_elements.append(cpp_variable)

def add_array(self, cpp_variable):
"""
Expand Down Expand Up @@ -405,12 +411,21 @@ def _render_enum_section(self, cpp):
enumItem.render_to_string(cpp)
cpp.newline()

def _render_variables_declaration(self, cpp):
def _render_private_variables_declaration(self, cpp):
"""
Render to string all contained variable class members
Method is protected as it is used by CppClass only
"""
for varItem in self.internal_private_variable_elements:
varItem.declaration().render_to_string(cpp)
cpp.newline()

def _render_public_variables_declaration(self, cpp):
"""
Render to string all contained variable class members
Method is protected as it is used by CppClass only
"""
for varItem in self.internal_variable_elements:
for varItem in self.internal_public_variable_elements:
varItem.declaration().render_to_string(cpp)
cpp.newline()

Expand Down Expand Up @@ -440,7 +455,8 @@ def render_static_members_implementation(self, cpp):
int MyClass::my_static_array[] = {}
"""
# generate definition for static variables
static_vars = [variable for variable in self.internal_variable_elements if variable.is_static]
static_vars = [variable for variable in self.internal_private_variable_elements if variable.is_static] \
+ [variable for variable in self.internal_public_variable_elements if variable.is_static]
for varItem in static_vars:
varItem.definition().render_to_string(cpp)
cpp.newline()
Expand Down Expand Up @@ -480,13 +496,14 @@ def class_interface(self, cpp):
self._render_enum_section(cpp)
self._render_internal_classes_declaration(cpp)
self._render_methods_declaration(cpp)
self._render_public_variables_declaration(cpp)

def private_class_members(self, cpp):
"""
Generates section of class member variables.
Should be placed in 'private:' section
"""
self._render_variables_declaration(cpp)
self._render_private_variables_declaration(cpp)
self._render_array_declaration(cpp)

def render_to_string(self, cpp):
Expand Down
7 changes: 6 additions & 1 deletion tests/test_cpp_file.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,16 @@ def test_cpp_class(self):

my_class.add_variable(CppVariable(name="m_var1",
type="int",
initialization_value='1'))
initialization_value='1'), is_private=False)

my_class.add_variable(CppVariable(name="m_var2",
type="int*"))

my_class.add_variable(CppVariable(name="m_var3",
type="int",
initialization_value='1', is_static=True),
is_private=False)

a2 = CppArray(name='array2', type='char*', is_const=True, is_static=True, )
a2.add_array_item('"Item1"')
a2.add_array_item('"Item2"')
Expand Down