Skip to content

Commit

Permalink
[PLAT-15714] Adding prometheus scrape timeout and interval to k8s
Browse files Browse the repository at this point in the history
Summary:
https://phorge.dev.yugabyte.com/D38836 only added the prometheus scrape timeout to YBA installer
deployments. This diff exposes both scrape timeout and scrape interval as values that user can
configure, which will then be reflected in prometheus.yml.

Test Plan: Deploy k8s and update scrapte timeout/interval

Reviewers: anijhawan, dshubin

Reviewed By: dshubin

Subscribers: amalyshev, yugaware

Differential Revision: https://phorge.dev.yugabyte.com/D39020
  • Loading branch information
mchiddy committed Oct 24, 2024
1 parent 9f1307a commit bcbf71b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 3 additions & 2 deletions stable/yugaware/templates/configs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -424,8 +424,9 @@ metadata:
data:
prometheus.yml: |
global:
scrape_interval: 10s
evaluation_interval: 10s
scrape_interval: {{ .Values.prometheus.scrapeInterval }}
evaluation_interval: {{ .Values.prometheus.scrapeInterval }}
scrape_timeout: {{ .Values.prometheus.scrapeTimeout }}
rule_files:
- '/opt/yugabyte/prometheus/rules/yugaware.ad.*.yml'
- '/opt/yugabyte/prometheus/rules/yugaware.recording-rules.yml'
Expand Down
2 changes: 2 additions & 0 deletions stable/yugaware/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,8 @@ prometheus:
queryConcurrency: 20
queryMaxSamples: 5000000
queryTimeout: 30s
scrapeTimeout: 10s
scrapeInterval: 10s
## Set this to false to disable scraping of Kubernetes worker
## nodes. Setting this to false will results in blank graphs of
## resource utilization for Kubernetes universes. Useful for
Expand Down

0 comments on commit bcbf71b

Please sign in to comment.