Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure clusterInfoMap does not become empty when external LB is given #25

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

ashetkar
Copy link

@ashetkar ashetkar commented Dec 4, 2024

What:

  • clusterInfoMap holds the information of each node (value of the entry) of the cluster against its address (key of the entry)
  • When the address given in connection string does not match with either the host value or the public_ip value of the node, the driver saves the information of the node against its public_ip and removes the entry saved against its host value.
  • But if host and public_ip values are same, the clusterInfoMap was losing the entry if the remove() operation is done after put() operation. So reversed the sequence.

Why:

Testing:

  • Verified the fix with the app which reproduced the issue
  • Existing tests pass

Copy link

@HarshDaryani896 HarshDaryani896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashetkar ashetkar merged commit 77b0ee8 into master Dec 4, 2024
4 of 5 checks passed
@ashetkar ashetkar deleted the gh_25153 branch December 4, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants