Fix for GH issue 11623 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When using the
YBClusterAwareDataSourcewith propertydataSource.portNumberto specify the port number, the driver was not updating the same in the data source. This was happening since the deprecated setter methodBaseDataSource.setPortNumber()was updating another fieldportNumbersinstead of the intendedportNumber(singular).Fix:
Update both these fields in
BaseDataSource.setPortNumber().Note:
The property
dataSource.additionalEndpoints, if specified, must include the respective port numbers. Otherwise, the driver will try to connect to them, when required, with the default port number (5433) and not withdataSource.portNumber.