-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge ALTER TABLE ddl with CREATE TABLE in case of Primary Key, Unique and Check Constraints #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54eafea
to
b9e229d
Compare
For Oracle and postgres complex schema tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yet to review tests.
makalaaneesh
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a nit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
TODO: Disable the feature.
Added a new transformer struct with method
MergeConstraints()
. In future we can add more to it.the new
table.sql
won't haveALTER TABLE ADD CONSTRAINT
ddl in case of Primary Key, Unique and Check ConstraintsFor example: the following ALTER ddls will be merged with CREATE
Performance Improvement - This change will reduce the time to half (2x improvement) for cases where PK is in a separate ALTER TABLE ddl than CREATE TABLE
Describe if there are any user-facing changes
table.sql
file will contain fewer ALTER table ddls.How was this pull request tested?
Added Unit tests.
Existing end to end tests are enough.
Verified with some end to end tests also.
Does your PR have changes that can cause upgrade issues?
table.sql
will contain lesser DDLs)