Skip to content

Commit

Permalink
[#25037]yugabyted: Node starts with hostname as advertise_address ins…
Browse files Browse the repository at this point in the history
…tead of private IP

Summary:
When starting a node, it starts with hostname as the advertise_address instead of the private IP of the machine.
This behaviour is due to the recent commit to support hostname-based docker deployments.
Fixing the issue.
Jira: DB-14171

Test Plan: Manual Testing

Reviewers: nikhil, djiang

Reviewed By: djiang

Subscribers: yugabyted-dev, sgarg-yb

Differential Revision: https://phorge.dev.yugabyte.com/D40181
  • Loading branch information
gargsans-yb committed Nov 21, 2024
1 parent f28ea76 commit f41c27b
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions bin/yugabyted
Original file line number Diff line number Diff line change
Expand Up @@ -7555,8 +7555,7 @@ class ControlScript(object):

if args.advertise_address is None:
if not self.configs.saved_data.get("advertise_address"):

if str(os.path.exists("/.dockerenv")):
if os.path.exists("/.dockerenv"):
args.advertise_address = self.find_hostname_of_node()
else:
if OS_NAME == "Linux":
Expand Down

0 comments on commit f41c27b

Please sign in to comment.