Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL][ASH] Collect wait events from TServer #20240

Closed
1 task done
hbhanawat opened this issue Dec 8, 2023 · 0 comments
Closed
1 task done

[YSQL][ASH] Collect wait events from TServer #20240

hbhanawat opened this issue Dec 8, 2023 · 0 comments
Assignees
@abhinab-yb
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@hbhanawat
Copy link
Contributor

hbhanawat commented Dec 8, 2023 •
edited by jira bot
Loading

Jira Link: DB-9201

Description

- Enable pulling of wait events from TServer and populating the circular buffer
- The number of samples to be collected should be driven by the gflag. Set the sample_weight accordingly

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@hbhanawat hbhanawat added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Dec 8, 2023
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Dec 8, 2023
@hbhanawat hbhanawat removed the status/awaiting-triage Issue awaiting triage label Dec 8, 2023
@hbhanawat hbhanawat mentioned this issue Dec 8, 2023
Open
55 tasks
@hbhanawat hbhanawat changed the title [YSQL][ActiveHistory] Collect wait events from TServer [YSQL][ASH] Collect wait events from TServer Jan 3, 2024
abhinab-yb added a commit that referenced this issue Jan 30, 2024
@abhinab-yb
[#20240] YSQL, ASH: Fetch ASH samples from local tserver
2eab548 
Summary:
D30484 / ce31f43 has introduced a new
RPC `ActiveSessionHistory` to fetch the ASH samples from the /rpcz endpoint. This
diff uses this RPC to fill up the circular buffer with ASH samples from the local tserver.

This diff doesn't implement any sampling logic at the tserver side, so the samples of
all the active RPCs are fetched.

A test flag `TEST_ash_debug_aux` is introduced to export the RPC `method` as the
aux info instead of `tablet_id`, this will be useful for debugging while developing ASH.
Jira: DB-9201

Test Plan: ./yb_build.sh --java-test TestYbAsh#testTServerSamples

Reviewers: jason

Reviewed By: jason

Subscribers: hbhanawat, yql, amitanand, bogdan

Differential Revision: https://phorge.dev.yugabyte.com/D30862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhinab-yb abhinab-yb

Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hbhanawat @yugabyte-ci @abhinab-yb