Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL][ActiveHistory] Background workers with postgres backends can crash due to an assertion failure in ASH #20338

Closed
1 task done
abhinab-yb opened this issue Dec 18, 2023 · 0 comments
Closed
1 task done

[YSQL][ActiveHistory] Background workers with postgres backends can crash due to an assertion failure in ASH #20338

abhinab-yb opened this issue Dec 18, 2023 · 0 comments
Assignees
@abhinab-yb
Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@abhinab-yb
Copy link
Contributor

abhinab-yb commented Dec 18, 2023 •
edited by jira bot
Loading

Jira Link: DB-9324

Description

Background workers may not have MyProcPort set. This results in a assertion failure and causes the background worker to crash.

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@abhinab-yb abhinab-yb added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Dec 18, 2023
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Dec 18, 2023
@abhinab-yb abhinab-yb self-assigned this Dec 18, 2023
@abhinab-yb abhinab-yb removed the status/awaiting-triage Issue awaiting triage label Dec 18, 2023
@abhinab-yb abhinab-yb mentioned this issue Dec 18, 2023
Open
55 tasks
@abhinab-yb abhinab-yb changed the title [YSQL][ActiveHistory] Background workers may have null MyProcPort resulting in an assertion failure [YSQL][ActiveHistory] Background workers can crash due to an assertion failure in ASH code Dec 18, 2023
@abhinab-yb abhinab-yb changed the title [YSQL][ActiveHistory] Background workers can crash due to an assertion failure in ASH code [YSQL][ActiveHistory] Background workers can crash due to an assertion failure in ASH Dec 18, 2023
@abhinab-yb abhinab-yb changed the title [YSQL][ActiveHistory] Background workers can crash due to an assertion failure in ASH [YSQL][ActiveHistory] Background workers with postgres backends can crash due to an assertion failure in ASH Dec 19, 2023
abhinab-yb added a commit that referenced this issue Dec 20, 2023
@abhinab-yb
[#20338] YSQL, ASH: Fix an assertion when ASH is enabled
48f7e3c 
Summary:
Background workers may not have MyProcPort set. This results in an assertion
failure in ASH code if a postgres backend was initialized by the background
worker and causes the background worker to crash. The assertion failure is only
hit when ASH is enabled. This assertion was incorrectly introduced by commit
de8c183

This diff checks and doesn't set client address in ASH metadata if MyProcPort is null,
i.e. when a background worker creates a postgres backend.
Jira: DB-9324

Test Plan: Jenkins: compile only

Reviewers: jason

Reviewed By: jason

Subscribers: amitanand, hbhanawat, yql

Differential Revision: https://phorge.dev.yugabyte.com/D31159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhinab-yb abhinab-yb

Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yugabyte-ci @abhinab-yb