Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB][ASH] Sizes of various ASH metadata fields are inconsistent #20454

Closed
1 task done
abhinab-yb opened this issue Jan 5, 2024 · 0 comments
Closed
1 task done

[DocDB][ASH] Sizes of various ASH metadata fields are inconsistent #20454

abhinab-yb opened this issue Jan 5, 2024 · 0 comments
Assignees
@abhinab-yb
Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@abhinab-yb
Copy link
Contributor

abhinab-yb commented Jan 5, 2024 •
edited by jira bot
Loading

Jira Link: DB-9456

Description

  • query_id is a 64 bit unsigned int in PG, but a 64 bit signed int in TServer
  • wait_status_code is a 32 bit unsigned int in TServer, but a 64 bit unsigned int in the protobuf

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@abhinab-yb abhinab-yb added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Jan 5, 2024
@yugabyte-ci yugabyte-ci added the kind/bug This issue is a bug label Jan 5, 2024
@abhinab-yb abhinab-yb self-assigned this Jan 5, 2024
@yugabyte-ci yugabyte-ci added the priority/medium Medium priority issue label Jan 5, 2024
@abhinab-yb abhinab-yb added kind/bug This issue is a bug priority/medium Medium priority issue and removed kind/bug This issue is a bug priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage labels Jan 5, 2024
@abhinab-yb abhinab-yb mentioned this issue Jan 5, 2024
Open
55 tasks
@abhinab-yb abhinab-yb changed the title [YSQL][ASH] Sizes of various ASH metadata fields are inconsistent [DocDB][ASH] Sizes of various ASH metadata fields are inconsistent Jan 5, 2024
@yugabyte-ci yugabyte-ci changed the title [DocDB][ASH] Sizes of various ASH metadata fields are inconsistent [YSQL][ASH] Sizes of various ASH metadata fields are inconsistent Jan 5, 2024
@abhinab-yb abhinab-yb changed the title [YSQL][ASH] Sizes of various ASH metadata fields are inconsistent [DocDB][ASH] Sizes of various ASH metadata fields are inconsistent Jan 5, 2024
abhinab-yb added a commit that referenced this issue Jan 5, 2024
@abhinab-yb
[#20454] DocDB, ASH: Fix inconsistent data sizes of ASH fields
71d7bde 
Summary:
This diff fixes the inconsistent sizes of various ASH fields

Upgrade/Rollback safety:
Safe to upgrade/downgrade. Protos only affect the new functionality -- ASH, and
do not interfere with existing functionality. ASH will be unavailable if downgraded.
TEST_yb_enable_ash is used to guard this feature.

Jira: DB-9456

Test Plan: ./yb_build.sh --cxx-test wait_state-test

Reviewers: amitanand, hbhanawat

Reviewed By: amitanand

Subscribers: ybase

Differential Revision: https://phorge.dev.yugabyte.com/D31503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhinab-yb abhinab-yb

Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yugabyte-ci @abhinab-yb