Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL][ASH] CREATE EXTENSION script fails when ASH is enabled #21030

Closed
1 task done
abhinab-yb opened this issue Feb 12, 2024 · 0 comments
Closed
1 task done

[YSQL][ASH] CREATE EXTENSION script fails when ASH is enabled #21030

abhinab-yb opened this issue Feb 12, 2024 · 0 comments
Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage

Comments

@abhinab-yb
Copy link
Contributor

abhinab-yb commented Feb 12, 2024 •
edited by jira bot
Loading

Jira Link: DB-10001

Description

Extension script returns syntax error due to incorrect parsing

Steps to reproduce

  1. Start a cluster
bin/yb-ctl start --tserver_flags="TEST_yb_enable_ash=true"
  1. Create an extension
yugabyte=# create extension adminpack;
ERROR:  unterminated /* comment at or near "/* ***********"

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@abhinab-yb abhinab-yb added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Feb 12, 2024
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Feb 12, 2024
@abhinab-yb abhinab-yb mentioned this issue Feb 12, 2024
Open
55 tasks
abhinab-yb added a commit that referenced this issue Feb 20, 2024
@abhinab-yb
[#21030] YSQL, ASH: Fix parse error while executing extension sql scr…
3911651 
…ipts

Summary:
D31784 / 066da33 introduced
a bug where the statements inside extension scripts had incorrect offset and
incorrect length which led to syntax errors due to incorrect parsing when ASH
was enabled.

This diff fixes the offset of the query just like pg_stat_statements.
Jira: DB-10001

Test Plan: ./yb_build.sh --java-test TestYbAsh#testNestedQueriesWithAsh

Reviewers: jason

Reviewed By: jason

Subscribers: hbhanawat, yql, amitanand

Differential Revision: https://phorge.dev.yugabyte.com/D32349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yugabyte-ci @abhinab-yb