Drop PgReplication physical connection after client disconnects with Ysql Conn Mgr #22816
Assignees
Labels
Comments
yugabyte-ci
added
jira-originated
kind/bug
manav-yb
pushed a commit
that referenced
this issue
Jun 28, 2024
…on manager Summary: Odyssey has the support for replication connections and makes them sticky through out the lifetime of logical connection. There are 3 bugs discussed below in ysql connection manager for replication connections which got exposed on running `TestPgReplicationSlot` test. # Once replication connection disconnects, the corresponding walsender process instead of getting shutdown, it goes back to the pool to get attached to next replication connection. This bug was recently fixed as [[ yandex/odyssey@ccd4dbf | commit ]] in upstream odyssey. Doing the same change in ysql connection manager as well. # In ysql connection manager, the session parameters received in the startup packet from the driver are never SET for the replication connections . Therefore it lead to different behaviour for replication connections with and without connection manager for the client. It is fixed by removing the special check for replication connections which doesn't let session variables to SET. # Avoid resetting SESSION variables for replication connections because replication connections are sticky for the life time of the connection in odyssey and the server (Walsender) process gets expired when replication connection disconnects so need to reset the GUC variables. Also as upstream odyssey provides full support for replication connection and resetting of GUC variable at end of transaction is introduced by ysql connection manager therefore matching the same behaviour. Jira: DB-11713 Test Plan: Jenkins: enable connection manager, test regex: .*TestPgReplicationSlot.* Reviewers: skumar, nkumar, asrinivasan Reviewed By: asrinivasan Subscribers: yql Differential Revision: https://phorge.dev.yugabyte.com/D35739
jasonyb
pushed a commit
that referenced
this issue
Jun 28, 2024
Summary: 9c637e2 [PLAT-14429]: Modify Troubleshooting Platform registration workflow in YBA 0a1406d [PLAT-14098]: Updating yb.runtime_conf_ui.tag_filter with appropriate tags value does not display the flags accordingly 70a87f9 [PLAT-13605][PLAT-13609]: Edit Volume controls and storage type in FULL_MOVE but not in case of UPDATE 26fbfe0 [PLAT-14515][UI] Clicking preview doesn't show the correct info and clears up the data provided while setting up the ysql_ident or ysql_hba multiline flags.- [PLAT-14514] [PLAT-14513] a07946b [#18233] Initial commit for yugabyted unit test framework. b2e8ee7 [#22842] docdb: Improve usability of stack trace tracking endpoints 508f26e [docs] Added RN 2.20.2.3-b2 (#23042) 214d44a [#22935] YSQL: Use db oid in the tserver's sequence cache entry key c47b2d9 [#22802] YSQL: Avoid renaming DocDb tables during legacy rewrite Excluded: 7c8343d [#22874] YSQL: Fix cascaded drops on columns 58c8d4e [#23046] xCluster: Remove ns_replication from the code a70681d [#22816] YSQL: Bug fixes for replication connections in ysql connection manager b239e07 Doc upgrade versions (#22988) Excluded: ec76062 [#16408] YSQL: Split TestPgRegressIndex.testPgRegressIndex Test Plan: Jenkins: rebase: pg15-cherrypicks Reviewers: jason, tfoucher Subscribers: yql Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D36247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-11713
The text was updated successfully, but these errors were encountered: