Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DocDB] Missing home icon in master UI #23275

Closed
1 task done
es1024 opened this issue Jul 24, 2024 · 1 comment
Closed
1 task done

[DocDB] Missing home icon in master UI #23275

es1024 opened this issue Jul 24, 2024 · 1 comment
Assignees
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@es1024
Copy link
Contributor

es1024 commented Jul 24, 2024

Jira Link: DB-12204

Description

Recent builds are missing an icon for the home button in master UI:

image

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@es1024 es1024 added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Jul 24, 2024
@es1024 es1024 self-assigned this Jul 24, 2024
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Jul 24, 2024
@es1024
Copy link
Contributor Author

es1024 commented Jul 24, 2024

Screenshot from 2024-07-24 09-40-29

es1024 added a commit that referenced this issue Jul 24, 2024
Summary:
D32082 / a6eff00 refactored master UI code, but
missed forwarding icon information to the underlying WebServer instance in some cases, namely
for the home entry in the navigation bar. This diff fixes that.

{image uri=https://github.com/user-attachments/assets/248fbbf1-dc53-46b2-9bca-627cccdbe886}
Jira: DB-12204

Test Plan:
Jenkins: compile only

Checked master UI locally.

Reviewers: hsunder

Reviewed By: hsunder

Subscribers: ybase

Differential Revision: https://phorge.dev.yugabyte.com/D36819
jasonyb pushed a commit that referenced this issue Jul 25, 2024
Summary:
 5aa0c0a [PLAT-14078] Add local provider test for update databases
 cdd97f8 remove ea badge (#23276)
 2813d78 [PLAT-14156][PLAT-14323]: Move all UI Driven flags to INTERNAL and remove YBM key as its not used
 49523f5 [PLAT-14733]: Add support for OIDC attributes jwt_jwks_path and jwt_jwks_url
 b039d1a [PLAT-14366] Basic local provider test for master auto failover
 700fd49 [#23275] docdb: Fix missing home icon on master UI
 89e434e [#13254] YSQL: import pgtap v1.3.3
 1b3585f [doc][cdc] Updated diagrams (#23262)
 399f165 [#23266] YSQL: Only require YB Admin privileges to run pg_locks
 5a4bbd4 [#19954] docdb: Register both tablet split children atomically
 b4c4294 [PLAT-14617] Add support for numerical search and enable extra search fields forxCluster
 84fb7ad [#22449] YSQL: wal2json YB specific changes
 afe84d4 [#13254] YSQL: add pgtap to build
 adf3c54 [#23272] YSQL, ASH: Fix incorrect popping of query id from nested query ids stack
 3b42c2e [docs] Add syntax documentation for logical replication (#23270)

Test Plan: Jenkins: rebase: pg15-cherrypicks

Reviewers: jason, tfoucher

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D36841
es1024 added a commit that referenced this issue Jul 26, 2024
Summary:
Original commit: 700fd49 / D36819
D32082 / a6eff00 refactored master UI code, but
missed forwarding icon information to the underlying WebServer instance in some cases, namely
for the home entry in the navigation bar. This diff fixes that.

{image uri=https://github.com/user-attachments/assets/248fbbf1-dc53-46b2-9bca-627cccdbe886}
Jira: DB-12204

Test Plan:
Jenkins: compile only

Checked master UI locally.

Reviewers: hsunder

Reviewed By: hsunder

Subscribers: ybase

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D36823
@es1024 es1024 closed this as completed Jul 26, 2024
@rthallamko3 rthallamko3 removed the status/awaiting-triage Issue awaiting triage label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

3 participants