Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tests from running with connection manager enabled #23837

Closed
yugabyte-ci opened this issue Sep 9, 2024 · 0 comments
Closed

Disable tests from running with connection manager enabled #23837

yugabyte-ci opened this issue Sep 9, 2024 · 0 comments
Assignees
Labels
2024.2.0_blocker area/ecosystem Label for all ecosystem related projects jira-originated kind/new-feature This is a request for a completely new feature priority/high High Priority

Comments

@yugabyte-ci
Copy link
Contributor

yugabyte-ci commented Sep 9, 2024

Jira Link: DB-12741

@yugabyte-ci yugabyte-ci added area/ecosystem Label for all ecosystem related projects jira-originated kind/new-feature This is a request for a completely new feature priority/high High Priority status/awaiting-triage Issue awaiting triage labels Sep 9, 2024
rahulb-yb added a commit that referenced this issue Sep 16, 2024
…with Connection Manager

Summary:
Some additional tests can be fixed when running with Connection Manager, using different methods. The list of the tests being fixed, along with method/reasoning of fix are stated below:

[DISABLED TESTS]
TestAlterTableWithConcurrentTxn.testTransactionConflictErrorCode - Disabled due to flakiness that needs further understanding.
TestPgAuthorization.testRevokeLoginMidSession - Disabled until better understanding of the problem.
TestPgAuthorization.testConnectionLimitDecreasedMidSession -  Disabled until better understanding of the problem.
PgYbHashCodeScanProjection.testScans - For this specific test, we would need to still remove connection manager debug + query logs in order to reduce flakiness, disabling test until we can make log levels configurable via common server flags.
PgYbStat.testYbTerminatedQueriesMultipleCauses -  Test is flaky with modifications via round robin killing of backends as the assertion check may pass or fail when checking if connection is still alive after having killed backend processes. Disabling test for now.

[TESTS WITHOUT WARMUP]
TestPgExplainAnalyze.testSeqScan - While running in any warmup mode, catalog read requests decrease, but not to the expected value of 0. Allow test to run in single connection mode until further analysis.
TestPgExplainAnalyze.testInsertValues - While running in any warmup mode, catalog read requests decrease, but not to the expected value of 0. Allow test to run in single connection mode until further analysis.
TestToastFunction.testSimple - Memory allocation is significantly higher with a pool of warmed up connections, allow the test to run with a single connection to allow metrics assertions to pass.

[TESTS WITH ROUND ROBIN ALLOCATION OF WARMED UP CONNECTIONS]
TestPgCostModelSeekNextEstimation.testSeekNextEstimationIndexScan - Modified to have round robin behaviour in an earlier diff, allow setUp to happen after having restarted the cluster in round robin mode.
TestPgCostModelSeekNextEstimation.testSeekNextEstimationBitmapScan - Modified to have round robin behaviour in an earlier diff, allow setUp to happen after having restarted the cluster in round robin mode.
Jira: DB-12674, DB-12699, DB-12741

Test Plan: Jenkins: enable connection manager, all tests

Reviewers: skumar, mkumar

Reviewed By: skumar

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D37826
jasonyb pushed a commit that referenced this issue Sep 17, 2024
Summary:
 f97d7d5 [#23770] [#23797] [#23837] YSQL: Fix most non-regress tests when run with Connection Manager
 ee2b108 [docs] reverted PR 23909 changes (#23941)
 bd80f4e [#23924] DocDB: Address recent flakiness of PgGetLockStatusTest.TestGetWaitStart
 Excluded: f0a5db7 [#20908] YSQL: Introduce interface to optimize index non-key column updates
 6556498 [#23897] xClusterDDLRepl: Support create table with partition by primary key
 e2b1d28 [#23363] Changing the default gflags of YSQL memory configuration.
 e717f43 [#23925] DocDB: Address recent regression of test PgWaitQueuesTest.MultiTabletFairness
 09b7702 [#23940] YSQL: Replace copyright string from YugaByteDB to YugabyteDB
 add83ef [#23947] Update callhome URL to use https
 69db717 Update faq page (#23704)
 Excluded: 063dbe5 [#23786] YSQL: yb_make_next_ddl_statement_nonincrementing
 Excluded: a913524 [#23859] YSQL: Remove redundant Bitmap Scan filters on partial indexes
 41f5afd [PLAT-15097]: Delete System platform DB table while disabling ysql
 d6bbf59 [#23890] docdb: Add filtering for bootstrap intent iterators based on min_replay_txn_start_ht
 0b37479 [#23770] YSQL: Stabalize TestPgExplainAnalyze#testExplainAnalyzeOptions the test with ysql connection manager

Test Plan: Jenkins: rebase: pg15-cherrypicks

Reviewers: jason, tfoucher

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D38123
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Sep 24, 2024
rahulb-yb added a commit that referenced this issue Sep 26, 2024
… enabled

Summary:
This diff (temporarily) disables the following tests when run with Connection Manager:

TestPgAuthorization.testAttributes- Role OID-based pool design is needed in addition to waiting for connection count-related statistics to pass (recreate user operations, connection limit per user checks). Note that conn limit per user support has been added - D33469, but the test was left to be modified as a TODO because of the need for ROLE OID pool support

TestPgAuthorization.testLongPasswords - Long passwords cause I/O errors with Connection Manager (this support is needed), this test further needs ROLE OID pooling support in order to pass
Jira: DB-12741

Test Plan: Jenkins: enable connection manager, test regex: .*testAttributes.*|.*LongPasswords.*

Reviewers: skumar

Reviewed By: skumar

Differential Revision: https://phorge.dev.yugabyte.com/D38379
fizaaluthra pushed a commit that referenced this issue Sep 27, 2024
Summary:
 12b2c40 [#23999] DocDB: Big shared memory segments
 b1e6329 [PLAT-15279] Add gzip compression to core dumps from DB.
 06472d5 [#24050] docdb: Fix re-packing rows after alter table add column with default value
 9009d11 [#23837] YSQL: Temporarily disable some tests with Connection Manager enabled
 11acca7 [#23325][#23326] yugabyted: Support for adding new databases for xCluster replication (Phase 2)
 96703da [PLAT-15465][PLAT-15466] Minor fixes in YNP
 c5aca3b [PLAT-14924][PLAT-12829][PLAT-15446] - ui bugs and improvements
 6e82692 [#23770] [#23797] YSQL: Stabilise some test failures with Connection Manager enabled
 b50bd1b [PLAT-15279] Adjusting the core pattern to create the cores with the core_ prefix for collect cores to catch it
 f692a60 [PLAT-14045] UBI-8 images don't have hostname
 d6a19da [PLAT-15377] Adding a global uncaught exception handler to yugaware
 acbb1ba [PLAT-15225] Verify there is no running master on nodes selected for master replacement
 Excluded: 3e93354 [#23686] YSQL: Build relcache foreign key list from YB catcache

Test Plan: Jenkins: rebase: pg15-cherrypicks

Reviewers: tfoucher, fizaa, telgersma

Differential Revision: https://phorge.dev.yugabyte.com/D38503
vpatibandla-yb added a commit that referenced this issue Oct 29, 2024
…ection manager

Summary: Disable the unit tests which are failing with connection manager when connection manager is turned on.

Test Plan: Jenkins: enable connection manager, all tests

Reviewers: skumar, mkumar, rbarigidad, devansh.saxena, stiwary

Reviewed By: rbarigidad

Differential Revision: https://phorge.dev.yugabyte.com/D39369
@yugabyte-ci yugabyte-ci reopened this Oct 31, 2024
rahulb-yb added a commit that referenced this issue Oct 31, 2024
…e failing with connection manager

Summary:
Disable the unit tests which are failing with connection manager when connection manager is turned on.

Original commit: e7e6d65 / D39369

Test Plan: Jenkins: enable connection manager, all tests

Reviewers: skumar, mkumar, devansh.saxena, stiwary

Reviewed By: skumar

Differential Revision: https://phorge.dev.yugabyte.com/D39595
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024.2.0_blocker area/ecosystem Label for all ecosystem related projects jira-originated kind/new-feature This is a request for a completely new feature priority/high High Priority
Projects
None yet
Development

No branches or pull requests

3 participants