Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] Ensure pushdown is disabled before upgrade #25607

Closed
1 task done
timothy-e opened this issue Jan 13, 2025 · 0 comments
Closed
1 task done

[YSQL] Ensure pushdown is disabled before upgrade #25607

timothy-e opened this issue Jan 13, 2025 · 0 comments
Assignees
@timothy-e
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@timothy-e
Copy link
Contributor

timothy-e commented Jan 13, 2025 •
edited by jira bot
Loading

Jira Link: DB-14855

Description

Add it to pg_upgrade --check

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@timothy-e timothy-e added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Jan 13, 2025
@timothy-e timothy-e self-assigned this Jan 13, 2025
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Jan 13, 2025
timothy-e added a commit that referenced this issue Jan 14, 2025
@timothy-e
[#25607] YSQL: Check pushdown is disabled before major version upgrade
a5efcb9 
Summary:
When pushdown is enabled during upgrade, queries can fail with cryptic errors like `ERROR:  did not find '}' at end of input node`.

Until #24730 - //Support for operator pushdown during upgrade// is done, we should more explicitly block upgrades when pushdown is disabled.
Jira: DB-14855

Test Plan:
```
./yb_build.sh release --cxx-test integration-tests_pg15_upgrade-test --gtest_filter Pg15UpgradeTest.CheckPushdownIsDisabled
```

Reviewers: hsunder

Reviewed By: hsunder

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D41200
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Jan 14, 2025
vpatibandla-yb pushed a commit that referenced this issue Jan 16, 2025
@timothy-e @vpatibandla-yb
[#25607] YSQL: Check pushdown is disabled before major version upgrade
4acfd0c 
Summary:
When pushdown is enabled during upgrade, queries can fail with cryptic errors like `ERROR:  did not find '}' at end of input node`.

Until #24730 - //Support for operator pushdown during upgrade// is done, we should more explicitly block upgrades when pushdown is disabled.
Jira: DB-14855

Test Plan:
```
./yb_build.sh release --cxx-test integration-tests_pg15_upgrade-test --gtest_filter Pg15UpgradeTest.CheckPushdownIsDisabled
```

Reviewers: hsunder

Reviewed By: hsunder

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D41200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timothy-e timothy-e

Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yugabyte-ci @timothy-e