Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YW] Edit Universe did not pick the last 3 nodes in the list when downsizing #3292

Closed
rao-vasireddy opened this issue Jan 8, 2020 · 0 comments
Closed

[YW] Edit Universe did not pick the last 3 nodes in the list when downsizing #3292

rao-vasireddy opened this issue Jan 8, 2020 · 0 comments
Assignees
@Arnav15
Labels
area/platform Yugabyte Platform kind/bug This issue is a bug priority/high High Priority

Comments

@rao-vasireddy
Copy link
Contributor

When a 9 node cluster was downsized, the expectation is that n7,n8 and n9 will be removed. In one case, YW actually picked n6,n7 and n9.
n8 was in the same AZ as n6 and should've been picked instead of n6. This was on 1.3.2.3
@rao-vasireddy rao-vasireddy added kind/bug This issue is a bug priority/high High Priority area/platform Yugabyte Platform labels Jan 8, 2020
@ramkumarvs ramkumarvs assigned Arnav15 and unassigned ramkumarvs Mar 31, 2020
Arnav15 added a commit that referenced this issue Apr 15, 2020
@Arnav15
[#3292]: Select the nodes with the highest index during a remove.
0854c28 
Summary:
During a shrink of a universe, we want the nodes with the highest index to be removed
first. We should therefore sort by the node idx and use the highest idx node to be removed.

Test Plan:
Added a unit test. Also verified by checking the configure step and verified the nodes in
the ToBeRemoved state were the ones with the highest index.

Reviewers: bogdan, sanketh, ram

Reviewed By: ram

Subscribers: jenkins-bot, yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D8294
This was referenced Sep 8, 2022
Open
Open
@ryan-ally ryan-ally mentioned this issue Jun 27, 2023
Open
This was referenced Nov 27, 2023
Open
Open
@nyndyny nyndyny mentioned this issue Nov 28, 2023
Open
This was referenced Nov 30, 2023
Open
Open
This was referenced Dec 20, 2023
Open
Open
This was referenced May 21, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arnav15 Arnav15

Labels
area/platform Yugabyte Platform kind/bug This issue is a bug priority/high High Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bmatican @ramkumarvs @Arnav15 @rao-vasireddy