Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] PR for Documentation for multiple subscription support with azure #11609

Merged
merged 4 commits into from
Mar 1, 2022
Merged

[docs] PR for Documentation for multiple subscription support with azure #11609

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
286a800
Added content; fixed list formatting.
lizayugabyte Feb 28, 2022
6efc9e8
Implemented review comments
lizayugabyte Mar 1, 2022
0c2ca10
copied changes to stable
lizayugabyte Mar 1, 2022
00aefed
Merge branch 'master' into Doc-PLAT-3115
lizayugabyte Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...st/yugabyte-platform/configure-yugabyte-platform/set-up-cloud-provider/azure.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ You can set a private DNS zone as follows:

![Private DNS: basics tab](/images/yb-platform/install/azure/private-dns-basics-tab.png)<br><br>

1. Navigate to the resource page and click **Settings > Virtual Network Links** on the left tab, as per the following illustration:<br><br>
1. Navigate to the resource page and click **Settings > Virtual Network Links**, as per the following illustration:<br><br>

![Resource menu](/images/yb-platform/install/azure/resource-menu.png)<br><br>

Expand Down Expand Up @@ -180,15 +180,15 @@ You set up a shared gallery image on Azure as follows:

1. Navigate to the VM and click **Capture** on the top menu.

1. Fill in the information and then choose the gallery and image definition you created in the previous steps, as per the following illustration:
1. Fill in the information and then choose the gallery and image definition you created in the previous steps, as per the following illustration:<br><br>

![img](/images/yb-platform/install/azure/shared-gallery-capture.png)

Ensure that the images are replicated to each region in which you are planning to use them. For example, configuration shown in the following illustration would only work for US East:
<br><br>Ensure that the images are replicated to each region in which you are planning to use them. For example, configuration shown in the following illustration would only work for US East:

![description](/images/yb-platform/install/azure/shared-gallery-replication.png)

1. To use the image in Yugabyte Platform, enter the image version's resource ID into the **Marketplace Image URN/Shared Gallery Image ID** field of the **Specify Region Info** dialog.


<br>Note that if you provide the resource ID, Yugabyte Platform infers the resource group from it. If you provide only the name, then Yugabyte Platform assumes that the resource group is the same as the group used in the cloud provider.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I haven't heard that we can provide only name. I think it should be a full URL otherwise it will be not picked up.
  2. This URL contains not only the resource group but subscription ID as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergeyPotachev I guess I misunderstood your comment in the doc ticket: "The part about Private DNS Zone looks good enough. Also we need to add similar comments to a part related to Shared gallery image." I thought you suggested to add the Note from "How to define a private DNS zone" section to "How to use a shared image gallery" section, which I did.

Could you let me know what comments you'd like to be added to the Shared gallery image section?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like I missed some things while was checking the Private DNS section. My apologies.
What we need to say:

  1. Private DNS zone could be id only and in such case it will be used together with default subscription id and resource group; If it has subscription id and resource group then they will be used instead of default values;
  2. Gallery Image ID could be a full URL only which should contain a subscription id, a resource group name and the resource name itself. If subscription id/resource group are different from the default ones, they will be used instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @SergeyPotachev.
Just to make sure I understand correctly, I have to do this:

  1. Delete "Note that if you provide the Resource ID, Yugabyte Platform infers the resource group from it. If you provide only the name, then Yugabyte Platform assumes that the resource group is the same as the group used in the cloud provider." from both sections.
  2. Add "Private DNS zone could be id only and in such case it will be used together with default subscription id and resource group; If it has subscription id and resource group then they will be used instead of default values." to the "How to define a private DNS zone" section.
  3. Add "Gallery Image ID could be a full URL only which should contain a subscription id, a resource group name and the resource name itself. If subscription id/resource group are different from the default ones, they will be used instead." to the "How to use a shared image gallery" section.

Could you, please, confirm?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For item 2. "if it has subscription ..." should be something like "if it is a full URL which contains subscription ID and resource group..."
All other things look good to me.