Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform] Remove commons-collections4 and use guava instead #8856

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

bhavin192
Copy link
Contributor

This is a follow up change from #8371

Scenarios tested:

  • Ran platform inside Kubernetes, curl the API, it returns the expected JSON.

This is a follow up change from yugabyte#8371

Scenarios tested:
- Ran platform inside Kubernetes, curl the API, it returns the expected JSON.

Signed-off-by: Bhavin Gandhi <[email protected]>
@bhavin192 bhavin192 requested a review from sb-yb June 11, 2021 09:14
Copy link
Contributor

@sb-yb sb-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Unrelated rant about your comment:

// Performs discovery of region, zones, pull secret, storageClass  
// when running inside a Kubernetes cluster. Returns the discovered  
// information as a JSON, which is similar to the one which is  
// passed to the createKubernetes method.

How much effort to change the other method to accept this form data? You say it is "similar". If its not much difference then lets bridge the gap.
You can leave it in different diff and do when time permits but please track it in a bug.

@bhavin192
Copy link
Contributor Author

@sb-yb good question. The thing is, some of the fields need to come from the frontend. Frontend is going to consume this API, add or modify some of the field (user might also modify). These are things like

  • The provider type (in Kubernetes we have OpenShift, Tanzu, GKE etc).
  • Lat Lon of the region (the region name might also change, as the frontend has a different way to name the regions).

Frontend -> Discovery API -> show pre-filled data to user -> User modifies or just accepts -> frontend calls the provider creation API.

The main issue where we are tracking this feature is still open, I will add the details there, as few things might change when the UI part of this is implemented.

@bhavin192 bhavin192 merged commit 05a007d into yugabyte:master Jun 11, 2021
@bhavin192 bhavin192 deleted the k8s-discovery-pr-8371-fix branch June 11, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants