Skip to content

2.25.1.0-b252

2.25.1.0-b252: [#25742] YSQL: alter database rename/owner must have global-impact
@myang2021 myang2021 tagged this 28 Jan 22:28 
Summary:
Commit 3b31c0b3a041f7ed33f53e4b149b92d2e81c7e9a has made several types of
alter database DDL statements non-global impact, including alter database rename
and alter database owner. It turns out that alter database rename and alter
database owner must have global-impact or else we run into problems. In case of
alter database rename, we can later have drop database hang, and for alter
database owner, we can later prevents/allows a database operation incorrectly.

I made changes to revert alter database rename/owner back to have global impact.
Added new unit tests that would fail if they were non-global impact.
Jira: DB-15024

Test Plan:
./yb_build.sh --cxx-test pg_catalog_version-test --gtest_filter PgCatalogVersionTest.AlterDatabaseRename
./yb_build.sh --cxx-test pg_catalog_version-test --gtest_filter PgCatalogVersionTest.AlterDatabaseOwner
./yb_build.sh --cxx-test pg_catalog_version-test --gtest_filter PgCatalogVersionTest.AlterDatabaseCatalogVersionIncrement

Reviewers: kfranz, mihnea, sanketh

Reviewed By: kfranz

Subscribers: yql, svc_phabricator

Differential Revision: https://phorge.dev.yugabyte.com/D41476
Assets 2
Loading