Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calls to Y.log in PluginHost are missing filter information #1943

Closed
tribis opened this issue Aug 17, 2014 · 1 comment
Closed

Calls to Y.log in PluginHost are missing filter information #1943

tribis opened this issue Aug 17, 2014 · 1 comment
Assignees
@okuryu

Comments

@tribis
Copy link
Contributor

tribis commented Aug 17, 2014

IN PluginHost.js 2 calls to Y.log are like so:
Y.log("Attempt to replug an already attached plugin, and we can't setAttrs, because it's not Attribute based: " + ns);
with no filter information. Due to this they are never shown in the log.
They should be:
Y.log("Attempt to replug an already attached plugin, and we can't setAttrs, because it's not Attribute based: " + ns, 'error', 'PluginHost');
tribis added a commit to tribis/yui3 that referenced this issue Aug 17, 2014
@tribis
Fix yui#1943. Calls to Y.log in PluginHost are missing filter informa…
28b1477 
…tion.
tribis added a commit to tribis/yui3 that referenced this issue Aug 17, 2014
@tribis
Fix yui#1943. Calls to Y.log in PluginHost are missing filter informa…
7c2c061 
…tion.
@tribis tribis mentioned this issue Aug 17, 2014
Merged
@okuryu okuryu self-assigned this Aug 18, 2014
@ybldr ybldr closed this as completed in b74d5f2 Aug 18, 2014
@okuryu
Copy link
Member

okuryu commented Aug 18, 2014

#1944 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@okuryu okuryu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@okuryu @tribis