Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ease tests running #203

Closed
panthony opened this issue Apr 5, 2018 · 1 comment
Closed

Ease tests running #203

panthony opened this issue Apr 5, 2018 · 1 comment
Labels
chore

Comments

@panthony
Copy link

panthony commented Apr 5, 2018

What is the current behavior?

npm test fails out of the box.

What is the expected behavior?

This command should works.

Or at least the README should provide easy step to make them run.

But would be better for 'npm test' to just work.

Maybe https://www.npmjs.com/package/redis-mock or similar?

What is the motivation / use case for changing the behavior?

Hard to motivate people to contribue and write tests when the tests won't run to begin with :)
@yujiosaka
Copy link
Owner

@panthony
Never thought of that! Thanks for a good issue!

@yujiosaka yujiosaka added the chore label Apr 6, 2018
@yujiosaka yujiosaka mentioned this issue Apr 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@panthony @yujiosaka