Separately run redis cache test #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 7, 2018 19:23
yujiosaka
commented
Apr 7, 2018
| @@ -45,8 +50,9 @@ | |||
| "eslint-plugin-import": "2.10.0", | |||
| "greenkeeper-lockfile": "1.14.0", | |||
| "mime": "2.2.1", | |||
| "mocha": "5.0.5", | |||
| "mocha": "mochajs/mocha#88b9882", | |||
There was a problem hiding this comment.
Mocha will support --exclude option in the next version.
See mochajs/mocha#3210
yujiosaka
force-pushed
the
separately-run-redis-cache-test
branch
from
6ffe2a1 to
000a777
Compare
yujiosaka
force-pushed
the
separately-run-redis-cache-test
branch
from
9420fa4 to
52eafc6
Compare
yujiosaka
pushed a commit
that referenced
this pull request
Apr 8, 2018
Separately run redis cache test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis tests didn't pass with redis-mock because it doesn't support
evalmethod. I'd simply separate Redis cache tests.Plus, I had to change the function style for Mocha not to use arrow function. See https://mochajs.org/#arrow-functions for the details.
Fixes #203
FYI @panthony