[velox]makes substrait parser parseType() virtual

yukkit · Dec 17, 2024 · 7880c7c · 7880c7c
1 parent e98df40
commit 7880c7c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/velox/substrait/SubstraitParser.h b/velox/substrait/SubstraitParser.h
@@ -38,7 +38,9 @@ class SubstraitParser {
       const ::substrait::NamedStruct& namedStruct);
 
   /// Parse Substrait Type.
-  TypePtr parseType(const ::substrait::Type& substraitType);
+  virtual TypePtr parseType(const ::substrait::Type& substraitType);
+
+  virtual ~SubstraitParser() = default;
 
   /// Parse Substrait ReferenceSegment.
   int32_t parseReferenceSegment(

diff --git a/velox/substrait/SubstraitToVeloxPlan.h b/velox/substrait/SubstraitToVeloxPlan.h
@@ -121,6 +121,10 @@ class SubstraitVeloxPlanConverter {
       const ::substrait::RelCommon& relCommon,
       const core::PlanNodePtr& noEmitNode);
 
+  void setSubstraitParser(std::shared_ptr<SubstraitParser> substraitParser) {
+    substraitParser_ = substraitParser;
+  }
+
  protected:
   /// Returns unique ID to use for plan node. Produces sequential numbers
   /// starting from zero.