This repository has been archived by the owner on Jul 8, 2021. It is now read-only.
Used Self more liberally #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whole point of the Self type annotation for traits is so you can refer to the type in question without adding another location to change the name of the type when refactoring the code.
|
It's because you can't do that. This doesn't build. Looks like we need Travis CI here. |
|
Yeah, I only just got around to actually trying to compile—it seemed so obvious I didn't think I'd need to check right away! The error message is very strange, too, telling you there's no associated item for the type you're implementing the trait on. I'll go file an issue on Rust. |
|
Anywhere I can track this issue? |
|
I filed it here. |
|
Most of the discussion is happening here apparently though: rust-lang/rust#31179 |
|
Thanks guys! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You're using the Self type annotation in your implementations of Default and From, but you're not referring to the type Self in the method bodies, which is the whole point of the annotation. :)