Skip to content

Commit

Permalink
Remove unused pd-ssd storageclass + make clusterIssuer optional
Browse files Browse the repository at this point in the history
In clusters where there's already a clusterissuer set up, we don't
need to run a cluster issuer ourselves.

Ref jupyterhub#3222
  • Loading branch information
yuvipanda committed Feb 14, 2025
1 parent e245286 commit 296e9e4
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 9 deletions.
2 changes: 2 additions & 0 deletions mybinder/templates/cluster-issuer.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{ if .Values.clusterIssuer.enabled }}
---
apiVersion: cert-manager.io/v1
kind: ClusterIssuer
Expand Down Expand Up @@ -28,3 +29,4 @@ spec:
- http01:
ingress:
class: nginx
{{- end }}
9 changes: 0 additions & 9 deletions mybinder/templates/pd-ssd.yaml

This file was deleted.

3 changes: 3 additions & 0 deletions mybinder/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -727,3 +727,6 @@ awsEcrRegistryCleaner:

localpv-provisioner:
enabled: false

clusterIssuer:
enabled: true

0 comments on commit 296e9e4

Please sign in to comment.