remove assertion

ywangd · Nov 18, 2024 · 2c8feed · 2c8feed
1 parent c33066e
commit 2c8feed
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/...org/elasticsearch/cluster/routing/allocation/allocator/DesiredBalanceShardsAllocator.java b/...org/elasticsearch/cluster/routing/allocation/allocator/DesiredBalanceShardsAllocator.java
@@ -151,17 +151,13 @@ protected void processInput(DesiredBalanceInput desiredBalanceInput) {
                 computationsExecuted.inc();
 
                 final DesiredBalance currentDesiredBalance = currentDesiredBalanceRef.get();
-                // Update is either not necessary (due to no changes) or the node has concurrently stands down as master
-                if (currentDesiredBalance.lastConvergedIndex() != index) {
-                    assert initialDesiredBalance.lastConvergedIndex() == currentDesiredBalance.lastConvergedIndex() // no change
-                        || currentDesiredBalance == DesiredBalance.NOT_MASTER
-                        || currentDesiredBalance == DesiredBalance.INITIAL : currentDesiredBalance + " vs " + initialDesiredBalance;
+                if (currentDesiredBalance == DesiredBalance.NOT_MASTER || currentDesiredBalance == DesiredBalance.INITIAL) {
                     logger.debug(
                         () -> Strings.format(
-                            "Desired balance computation for [%s] is discarded. Current=[%s], Initial=[%s]",
+                            "Desired balance computation for [%s] is discarded since master has concurrently changed. "
+                                + "Current desiredBalance=[%s]",
                             index,
-                            currentDesiredBalance,
-                            initialDesiredBalance
+                            currentDesiredBalance
                         )
                     );
                 } else if (currentDesiredBalance.finishReason() == DesiredBalance.ComputationFinishReason.STOP_EARLY) {