more fix

ywangd · Nov 18, 2024 · a432406 · a432406
1 parent 0b03f4e
commit a432406
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/...org/elasticsearch/cluster/routing/allocation/allocator/DesiredBalanceShardsAllocator.java b/...org/elasticsearch/cluster/routing/allocation/allocator/DesiredBalanceShardsAllocator.java
@@ -294,15 +294,15 @@ private void setCurrentDesiredBalance(DesiredBalance newDesiredBalance) {
         });
 
         if (updatedDesiredBalance == newDesiredBalance) {
+            assert oldDesiredBalance.get() != null;
             if (logger.isTraceEnabled()) {
-                var diff = DesiredBalance.hasChanges(updatedDesiredBalance, newDesiredBalance)
-                    ? "Diff: " + DesiredBalance.humanReadableDiff(updatedDesiredBalance, newDesiredBalance)
+                var diff = DesiredBalance.hasChanges(oldDesiredBalance.get(), newDesiredBalance)
+                    ? "Diff: " + DesiredBalance.humanReadableDiff(oldDesiredBalance.get(), newDesiredBalance)
                     : "No changes";
                 logger.trace("Desired balance updated: {}. {}", newDesiredBalance, diff);
             } else {
                 logger.debug("Desired balance updated for [{}]", newDesiredBalance.lastConvergedIndex());
             }
-            assert oldDesiredBalance.get() != null;
             computedShardMovements.inc(DesiredBalance.shardMovements(oldDesiredBalance.get(), newDesiredBalance));
         } else {
             logger.debug("discard desired balance for [{}]", newDesiredBalance.lastConvergedIndex());