feat(transcoding): added better error handling

zZHorizonZz · Apr 28, 2024 · 778e2de · 778e2de
1 parent b4fe2d6
commit 778e2de
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/...ions/grpc/runtime/src/main/java/io/quarkus/grpc/transcoding/GrpcTranscodingHttpUtils.java b/...ions/grpc/runtime/src/main/java/io/quarkus/grpc/transcoding/GrpcTranscodingHttpUtils.java
@@ -20,7 +20,7 @@ public class GrpcTranscodingHttpUtils {
      * @param pathTemplate The gRPC path template defining the expected structure.
      * @return `true` if the paths match, `false` otherwise.
      */
-    public static boolean isPathMatch(String requestPath, String pathTemplate) {
+    public static boolean isPathMatch(String pathTemplate, String requestPath) {
         int pathIndex = 0;
         int templateIndex = 0;
 
@@ -69,7 +69,7 @@ public static Map<String, String> extractPathParams(String pathTemplate, String
         String[] pathParts = httpPath.split("/");
         String[] templateParts = pathTemplate.split("/");
 
-        if(pathParts.length != templateParts.length) {
+        if (pathParts.length != templateParts.length) {
             return extractedParams;
         }
 

diff --git a/...e/src/test/java/io/quarkus/grpc/runtime/transcoding/GrpcTranscodingMessageWriterTest.java b/...e/src/test/java/io/quarkus/grpc/runtime/transcoding/GrpcTranscodingMessageWriterTest.java
@@ -12,6 +12,7 @@
 
 import io.quarkus.grpc.transcoding.GrpcTranscodingMessageWriter;
 import io.vertx.core.buffer.Buffer;
+import io.vertx.core.json.DecodeException;
 
 /**
  * Tests for {@link GrpcTranscodingMessageWriter}. In this test class, we test the utility methods that are used to merge
@@ -52,7 +53,7 @@ void testMergeParametersNoPayload() {
     @DisplayName("Test mergeParameters with invalid payload")
     void testMergeParametersInvalidPayload() {
         Buffer invalidPayload = Buffer.buffer("this is not json");
-        assertThrows(IllegalArgumentException.class, () -> {
+        assertThrows(DecodeException.class, () -> {
             GrpcTranscodingMessageWriter.mergeParameters(new HashMap<>(), new HashMap<>(), invalidPayload);
         });
     }