Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proxy volumes #113

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Fix proxy volumes #113

merged 1 commit into from
Nov 18, 2024

Conversation

Elbandi
Copy link
Contributor

@Elbandi Elbandi commented Oct 21, 2024 •
edited
Loading

What this PR does / why we need it:

When zabbixAgent has extraVolumes values, but zabbixProxy has not, the generated zabbix proxy manifest is invalid:

  imagePullSecrets:
    - configMap:
        name: userparameters
      name: userparameters-volume

(volume: yaml name is missing)

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

@Elbandi Elbandi requested a review from aeciopires as a code owner October 21, 2024 17:49
@aeciopires aeciopires added bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers labels Nov 18, 2024
aeciopires
aeciopires approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@aeciopires aeciopires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Elbandi for your contribution!

@aeciopires aeciopires merged commit 6454a02 into zabbix-community:master Nov 18, 2024
1 check failed
@Elbandi Elbandi deleted the fix-proxy-volumes branch November 18, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeciopires aeciopires aeciopires approved these changes

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Elbandi @aeciopires