Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve events #24

Closed
3 tasks done
zaboco opened this issue Dec 6, 2016 · 1 comment
Closed
3 tasks done

Improve events #24

zaboco opened this issue Dec 6, 2016 · 1 comment

Comments

@zaboco
Copy link
Owner

zaboco commented Dec 6, 2016 •
edited
Loading

  • remove onMouseDown since it can be handled via {Html,Svg}.Events
  • add key + Position to onDragStart (also ignore initial onDragBy event, since it is batched with onDragStart and order is not guaranteed)
  • add key + Position to onClick
@zaboco
Copy link
Owner Author

zaboco commented Dec 8, 2016

Fixes #23

zaboco added a commit that referenced this issue Dec 8, 2016
@zaboco
remove redundant tests #24
1e718f3
zaboco added a commit that referenced this issue Dec 8, 2016
@zaboco
remove onMouseDown #24
0650790
zaboco added a commit that referenced this issue Dec 8, 2016
@zaboco
add key to DraggingTentative state #24
99ec152
zaboco added a commit that referenced this issue Dec 8, 2016
@zaboco
onDragBy now also takes element key as arg #24
889c655
zaboco added a commit that referenced this issue Dec 8, 2016
@zaboco
initial Drag no longer emits onDragAt, only onDragStart #24
dc4ed5a
zaboco added a commit that referenced this issue Dec 8, 2016
@zaboco
make onMouseDown take key & remove onMouseDownKeyed #24
cc8a44e
zaboco added a commit that referenced this issue Dec 8, 2016
@zaboco
add smoke-test script #24
acba741
zaboco added a commit that referenced this issue Dec 8, 2016
@zaboco
remove deprecated triggerOnMouseDown #24
e12688b
zaboco added a commit that referenced this issue Dec 8, 2016
@zaboco
represent emitted Cmd as a Maybe instead of a List #24. That`s becaus…
1194628 
…e there should never be more than 1 message emitted at once, since Cmd.batch order is non-deterministic
zaboco added a commit that referenced this issue Dec 8, 2016
@zaboco
add key to onClick #24
8e57775
@zaboco zaboco mentioned this issue Dec 8, 2016
Merged
@zaboco zaboco closed this as completed in #26 Dec 8, 2016
zaboco added a commit that referenced this issue Dec 8, 2016
@zaboco
Merge pull request #26 from zaboco/24-improve-events
9a96349 
#24 Improve events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zaboco