Passing by #21
Closed
Passing by #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a pretty serious performance hit: i'm seeing up to maybe 30% longer benchmarks for some kickoffs. Passing by is absolutely critical, of course, but I wonder if I'm missing some performance improvements.
|
Thanks!! (I don't like the WIP commits, so I'm going to squash these before merging.) |
|
The performance hit looks fine on my machine (~2%) for the depth-3 kickoff, which is the one I've been paying the most attention to. |
| @@ -1,4 +1,4 @@ | |||
| #![feature(non_ascii_idents, pattern, plugin, test, question_mark)] | |||
| #![feature(iter_arith, non_ascii_idents, pattern, plugin, test, question_mark)] | |||
There was a problem hiding this comment.
iter_arith is stable as of the July 3 nightly (which is part of 1.11.0, as the awesome compiler warning will tell you).
|
💖 418cb0a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the final part of the official game spec.
This is unfortunately a very heavy performance hit. I'm not seeing anything obvious that i did stupidly, but I did see kickoff benchmarks increase by ~30%, which is a bummer.