Merge pull request #32 from zackurben/feature/add-apo-like-indicators

Feature/add apo like indicators
zackurben · Nov 12, 2017 · eb86f1a · eb86f1a
2 parents 7b4d28a + 61ebda6
commit eb86f1a
Show file tree

Hide file tree

Showing 7 changed files with 57 additions and 5 deletions.
diff --git a/lib/technical.js b/lib/technical.js
@@ -41,6 +41,15 @@ module.exports = config => {
       signalmatype
     });
 
+  /**
+   * A generic function generator for apo-like technicals.
+   * 
+   * @param {String} fn
+   *   The apo-like function to use 
+   */
+  const APO_LIKE = fn => (symbol, interval, series_type, fastperiod, slowperiod, matype) =>
+    util.fn(fn)({ symbol, interval, series_type, fastperiod, slowperiod, matype });
+
   return {
     sma: SMA_LIKE('SMA'),
     ema: SMA_LIKE('EMA'),
@@ -64,6 +73,8 @@ module.exports = config => {
     willr: SMA_LIKE('WILLR'),
     adx: SMA_LIKE('ADX'),
     adxr: SMA_LIKE('ADXR'),
+    apo: APO_LIKE('APO'),
+    ppo: APO_LIKE('PPO'),
     mom: SMA_LIKE('MOM'),
     bop: SMA_LIKE('BOP'),
     cci: SMA_LIKE('CCI'),

diff --git a/lib/util.js b/lib/util.js
@@ -78,6 +78,8 @@ const keys = {
   'Technical Analysis: WILLR': 'data',
   'Technical Analysis: ADX': 'data',
   'Technical Analysis: ADXR': 'data',
+  'Technical Analysis: APO': 'data',
+  'Technical Analysis: PPO': 'data',
   'Technical Analysis: MOM': 'data',
   'Technical Analysis: BOP': 'data',
   'Technical Analysis: CCI': 'data',
@@ -143,6 +145,7 @@ const keys = {
   '5.3: Signal Period': 'signalperiod',
   '5.3: SlowK MA Type': 'slowkmatype',
   '5.3: FastD MA Type': 'fastdmatype',
+  '5.3: MA Type': 'matype',
   '5.4: Fast MA Type': 'fastmatype',
   '5.4: SlowD Period': 'slowdperiod',
   '5.5: Slow MA Type': 'slowmatype',

diff --git a/test/crypto.js b/test/crypto.js
@@ -4,7 +4,7 @@ jasmine.DEFAULT_TIMEOUT_INTERVAL = 30000;
 jest.unmock('request-promise-native');
 const alpha = require('../')();
 const delay = require('delay');
-const TIME = 4000;
+const TIME = 5000;
 
 test(`intraday crypto works`, () => {
   expect.assertions(2);

diff --git a/test/data.js b/test/data.js
@@ -4,7 +4,7 @@ jasmine.DEFAULT_TIMEOUT_INTERVAL = 30000;
 jest.unmock('request-promise-native');
 const alpha = require('../')();
 const delay = require('delay');
-const TIME = 4000;
+const TIME = 5000;
 
 test(`intraday data works`, () => {
   expect.assertions(2);

diff --git a/test/forex.js b/test/forex.js
@@ -4,7 +4,7 @@ jasmine.DEFAULT_TIMEOUT_INTERVAL = 30000;
 jest.unmock('request-promise-native');
 const alpha = require('../')();
 const delay = require('delay');
-const TIME = 4000;
+const TIME = 5000;
 
 test(`forex data works`, () => {
   expect.assertions(3);

diff --git a/test/performance.js b/test/performance.js
@@ -4,7 +4,7 @@ jasmine.DEFAULT_TIMEOUT_INTERVAL = 30000;
 jest.unmock('request-promise-native');
 const alpha = require('../')();
 const delay = require('delay');
-const TIME = 4000;
+const TIME = 5000;
 
 test(`sector performance data works`, () => {
   expect.assertions(11);

diff --git a/test/technical.js b/test/technical.js
@@ -4,7 +4,7 @@ jasmine.DEFAULT_TIMEOUT_INTERVAL = 30000;
 jest.unmock('request-promise-native');
 const alpha = require('../')();
 const delay = require('delay');
-const TIME = 4000;
+const TIME = 5000;
 
 test(`sma data works`, () => {
   expect.assertions(9);
@@ -325,6 +325,44 @@ test(`adxr data works`, () => {
     });
 });
 
+test(`apo data works`, () => {
+  expect.assertions(11);
+  return delay(TIME)
+    .then(() => alpha.technical.apo(`msft`, `daily`, `close`))
+    .then(data => {
+      expect(data['Meta Data']).toBeDefined();
+      expect(data['Meta Data']['1: Symbol']).toEqual('msft');
+      expect(data['Meta Data']['2: Indicator']).toEqual('Absolute Price Oscillator (APO)');
+      expect(data['Meta Data']['3: Last Refreshed']).toBeDefined();
+      expect(data['Meta Data']['4: Interval']).toEqual('daily');
+      expect(data['Meta Data']['5.1: Fast Period']).toEqual(12);
+      expect(data['Meta Data']['5.2: Slow Period']).toEqual(26);
+      expect(data['Meta Data']['5.3: MA Type']).toEqual(0);
+      expect(data['Meta Data']['6: Series Type']).toEqual('close');
+      expect(data['Meta Data']['7: Time Zone']).toBeDefined();
+      expect(data['Technical Analysis: APO']).toBeDefined();
+    });
+});
+
+test(`ppo data works`, () => {
+  expect.assertions(11);
+  return delay(TIME)
+    .then(() => alpha.technical.ppo(`msft`, `daily`, `close`))
+    .then(data => {
+      expect(data['Meta Data']).toBeDefined();
+      expect(data['Meta Data']['1: Symbol']).toEqual('msft');
+      expect(data['Meta Data']['2: Indicator']).toEqual('Percentage Price Oscillator (PPO)');
+      expect(data['Meta Data']['3: Last Refreshed']).toBeDefined();
+      expect(data['Meta Data']['4: Interval']).toEqual('daily');
+      expect(data['Meta Data']['5.1: Fast Period']).toEqual(12);
+      expect(data['Meta Data']['5.2: Slow Period']).toEqual(26);
+      expect(data['Meta Data']['5.3: MA Type']).toEqual(0);
+      expect(data['Meta Data']['6: Series Type']).toEqual('close');
+      expect(data['Meta Data']['7: Time Zone']).toBeDefined();
+      expect(data['Technical Analysis: PPO']).toBeDefined();
+    });
+});
+
 test(`mom data works`, () => {
   expect.assertions(9);
   return delay(TIME)