Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate into PowerToys #215

Merged
merged 115 commits into from
Dec 18, 2024
Merged

Integrate into PowerToys #215

merged 115 commits into from
Dec 18, 2024

Conversation

stefansjfw
Copy link
Collaborator

  • Integrated into PowerToys - add module iface project
  • Added settings page
  • Added to installer
  • CI updates to sign msix and it's content and to check if msix content is signed

TODO:

  • see how to install msix dependencies automatically
  • Start app automatically after installing from settings?
  • Installed by default?

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check-spelling found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

<Directory Id="CmdPalInstallFolder" Name="CmdPal">
<Directory Id="CmdPalDepsInstallFolder" Name="Dependencies">
<?if $(sys.BUILDARCH) = x64 ?>
<Directory Id="CmdPalDepsx64InstallFolder" Name="x64" />

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

Depsx is not a recognized word. (unrecognized-spelling)
</DirectoryRef>

<?if $(sys.BUILDARCH) = x64 ?>
<DirectoryRef Id="CmdPalDepsx64InstallFolder" FileSource="$(var.BinDir)\WinUI3Apps\CmdPal.POC\AppPackages\Microsoft.CmdPal.UI.Poc_$(var.Version).0_Test\Dependencies\x64">

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

Depsx is not a recognized word. (unrecognized-spelling)
<RemoveFolder Id="RemoveCmdPalInstallDirFolder" Directory="CmdPalInstallFolder" On="uninstall"/>
<RemoveFolder Id="RemoveCmdPalDepsInstallDirFolder" Directory="CmdPalDepsInstallFolder" On="uninstall"/>
<?if $(sys.BUILDARCH) = x64 ?>
<RemoveFolder Id="RemoveCmdPalDepsx64InstallDirFolder" Directory="CmdPalDepsx64InstallFolder" On="uninstall"/>

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

Depsx is not a recognized word. (unrecognized-spelling)
<RemoveFolder Id="RemoveCmdPalInstallDirFolder" Directory="CmdPalInstallFolder" On="uninstall"/>
<RemoveFolder Id="RemoveCmdPalDepsInstallDirFolder" Directory="CmdPalDepsInstallFolder" On="uninstall"/>
<?if $(sys.BUILDARCH) = x64 ?>
<RemoveFolder Id="RemoveCmdPalDepsx64InstallDirFolder" Directory="CmdPalDepsx64InstallFolder" On="uninstall"/>

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

Depsx is not a recognized word. (unrecognized-spelling)

This comment has been minimized.

@zadjii-msft zadjii-msft merged commit 291838a into main Dec 18, 2024
5 of 6 checks passed
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

Depsx

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:zadjii-msft/PowerToys.git repository
on the stefan/make_it_a_module branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' |
perl - 'https://github.com/zadjii-msft/PowerToys/actions/runs/12398627968/attempts/1'

OR

To have the bot accept them for you, comment in the PR quoting the following line:
@check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@zadjii-msft zadjii-msft mentioned this pull request Dec 18, 2024
zadjii-msft added a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants