Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the non-labs markdown block #240

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

zadjii-msft
Copy link
Owner

Revert to the shipped, older MD block, cause CFS hates us

@zadjii-msft
Copy link
Owner Author

@stefansjfw this one's for you

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (185)
ACVS
adaptivecards
affordances
agressive
agressively
Aliias
Allman
apicontract
APPICONREFERENCE
APPMODEL
APPPUBLISHER
asynchonously
AVery
BNDBk
bodgy
Bools
builttoroam
BYEXENAME
Cantarell
cdn
channelurl
CLSIDs
cmdpal
commandpalette
contextitems
contractversion
cpcontrols
CREATETHREAD
CREATEWINDOW
cswin
Ctl
CVS
datas
DDEAPPLICATION
DDECOMMAND
DDEIFEXEC
DDETOPIC
defaultlib
DEFAULTTOFOLDER
DEFAULTTOSTAR
DELEGATEEXECUTE
devpal
dic
dragable
Droid
DROPTARGET
emoji
Errrors
ESPN
extensionsdk
favourites
filterbox
Fira
flaticon
footgunning
fpvm
Fqc
FRIENDLYAPPNAME
FRIENDLYDOCNAME
getcommand
gifv
gitroot
googleapis
Griese
gsl
Hande
harcoded
HKC
homies
HSSH
icf
icommanditems
icommandprovider
icondatatype
idk
ieq
iextn
IGNOREBASECLASS
IGo
imgflip
imgur
implementaions
implmenting
inbox
infotip
INLINEPREFIX
inotifypropchanged
intederminate
INVALIDCALL
INVALIDINDEX
isection
keyboardtester
Keychain
kinda
libraryincludes
libucrt
libucrtd
listpage
localappdata
LTk
LUQ
lvm
MBM
mdpvm
meme
memicmp
microwaved
minwindef
mobileredirect
mtu
murmurhash
MVVMTK
NGQt
nicksnettravels
NOFIXUPS
nonspace
NOOPEN
NOREMAPCLSID
NOTRUNCATE
NOUSERSETTINGS
NTZm
nullness
optionalcolor
OWMt
OWRj
paintin
Playbadge
Poc
Podcasts
Pokedex
Puser
QUICKTIP
QXZ
raisee
Rasterization
realease
reblogs
refelct
refering
REGISTERCLASSEX
REMAPRUNDLL
renamve
rsdk
searchtext
seearch
seperators
SFBS
sharepoint
SHELLEXTENSION
SHELLNEWVALUE
shich
shurg
somee
sooon
sourced
sourcedoc
Spongebob
spongebot
stdcpp
throughs
TIcon
TILEINFO
tlc
TLDR
ucrt
ucrtd
unistalls
videourl
vkey
VMs
vulnerbilities
wasdk
WCT
Wholegrain
wic
WUX
xclip
xdoc
XJSNh
ycombinator
youtube
YTM
zadjii
ZXk
ZXNs
Previously acknowledged words that are now absent BODGY Emoji Infotip IPC Managed Message pef Pipe SYSTEMWOW VKey Way Wbemidl WIC 🫥
Some files were automatically ignored 🙈

These sample patterns would exclude them:

^\Qsrc/modules/cmdpal/doc/initial-sdk-spec/list-elements-mock-002.pdn\E$
^\Qsrc/modules/cmdpal/Exts/PokedexExtension/Pages/PokedexExtensionPage.cs\E$

You should consider adding them to:

.github/actions/spell-check/excludes.txt

File matching is via Perl regular expressions.

To check these files, more of their words need to be in the dictionary than not. You can use patterns.txt to exclude portions, add items to the dictionary (e.g. by adding them to allow.txt), or fix typos.

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words and update file exclusions, you could run the following commands

... in a clone of the [email protected]:zadjii-msft/PowerToys.git repository
on the dev/migrie/f/revert-md-block branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/zadjii-msft/PowerToys/actions/runs/12378196050/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (1921) from .github/actions/spell-check/expect.txt and unrecognized words (185)

Dictionary Entries Covers Uniquely
cspell:npm/dict/npm.txt 302 1 1
cspell:r/src/r.txt 543 1 1
cspell:cpp/src/people.txt 23 1
cspell:cpp/src/ecosystem.txt 51 1

Consider adding them (in .github/workflows/spelling2.yml) for uses: check-spelling/[email protected] in its with:

      with:
        extra_dictionaries:
          cspell:npm/dict/npm.txt
          cspell:r/src/r.txt
          cspell:cpp/src/people.txt
          cspell:cpp/src/ecosystem.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling2.yml) for uses: check-spelling/[email protected] in its with:

check_extra_dictionaries: ''
Pattern suggestions ✂️ (2)

You could add these patterns to .github/actions/spell-check/patterns.txt:

# Automatically suggested patterns
# hit-count: 1 file-count: 1
# Amazon
\bamazon\.com/[-\w]+/(?:dp/[0-9A-Z]+|)

# hit-count: 1 file-count: 1
# imgur
\bimgur\.com/[^.]+

Errors (5)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
ℹ️ binary-file 1
ℹ️ candidate-pattern 2
❌ check-file-path 685
❌ forbidden-pattern 4
ℹ️ noisy-file 1

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@zadjii-msft zadjii-msft changed the title Use the non-labs markdown block, because pain and suffering Use the non-labs markdown block Dec 17, 2024
@stefansjfw stefansjfw merged commit 8214331 into main Dec 18, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants