Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Write implementation for Vec #13

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Add Write implementation for Vec #13

merged 1 commit into from
Apr 12, 2024

Conversation

jess-sol
Copy link
Contributor

Allows for writing to a Vec which has a custom allocator. This allows crates which implement a Write interface but not allocator-api2 to still write to a Vec with a custom allocator.

zakarumych
zakarumych requested changes Apr 11, 2024
View reviewed changes
Copy link
Owner

@zakarumych zakarumych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is copy of the standard Write for Vec, right?
In this case the only one detail missing is putting it under feature flag.

src/stable/vec/mod.rs Show resolved Hide resolved
@jess-sol
Copy link
Contributor Author

Yep copied it from latest stable 👍

@jess-sol jess-sol requested a review from zakarumych April 11, 2024 15:23
@zakarumych
Copy link
Owner

Looks great! Thank you!

@zakarumych zakarumych merged commit c50521d into zakarumych:main Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakarumych zakarumych Awaiting requested review from zakarumych

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jess-sol @zakarumych