Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: additionalPrinterColumns for PlatformCredentialsSet #2365

Merged
merged 2 commits into from
Jul 29, 2019

Conversation

hjacobs
Copy link
Contributor

@hjacobs hjacobs commented Jul 29, 2019

Adding additionalPrinterColumns makes kubectl and kube-web-view much more useful:
Screenshot_2019-07-29 platformcredentialssets - Kubernetes Web UI(1)

Sadly the CRD JSONPath only supports simple expression, i.e. there is no way to show the number of clients/tokens (would require some length() function) or the keys of maps (to list token names or similar). Related K8s issue to support complex stuff in CRD JSONPath: kubernetes/kubernetes#67268

@aermakov-zalando
Copy link
Contributor

Application is fine, but I disagree with adding errors/problems. We could easily add a status field in credentials-provider to show whether the PCS is healthy or not, but printing raw errors makes the output of zkubectl get pod pretty much unreadable.

@hjacobs
Copy link
Contributor Author

hjacobs commented Jul 29, 2019

@aermakov-zalando OK, agreed, will change accordingly and add a new status field.

@hjacobs hjacobs force-pushed the platformcredentialsset-columns branch from b215145 to bbc33f9 Compare July 29, 2019 13:22
@aermakov-zalando
Copy link
Contributor

👍

1 similar comment
@hjacobs
Copy link
Contributor Author

hjacobs commented Jul 29, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants