Allow static cpu manager policy to be enabled on nodepools #2446
Conversation
| @@ -69,6 +69,8 @@ clusters: | |||
| profile: ${WORKER_PROFILE}-splitaz | |||
| min_size: 3 | |||
| max_size: 21 | |||
| config_items: | |||
| cpu_manager_policy: static | |||
| - discount_strategy: spot_max_price | |||
| instance_types: ["m4.large", "m5.large", "m5.xlarge", "m4.xlarge"] | |||
There was a problem hiding this comment.
Does it mean that the cpu_manager_policy can be set only in the node pools with these type of instances?
There was a problem hiding this comment.
No, those are just our end to end tests where we create nodepools.
arjunrn
force-pushed
the
static-cpu-manager
branch
from
41b05d0 to
9e7a63c
Compare
|
👍 |
| @@ -69,6 +69,8 @@ clusters: | |||
| profile: ${WORKER_PROFILE}-splitaz | |||
| min_size: 3 | |||
| max_size: 21 | |||
| config_items: | |||
| cpu_manager_policy: static | |||
There was a problem hiding this comment.
wrong name: cpu_manager_policy != cpu_management_policy
| @@ -52,6 +52,9 @@ write_files: | |||
| featureGates: | |||
| SupportPodPidsLimit: true | |||
| podPidsLimit: {{ .NodePool.ConfigItems.pod_max_pids }} | |||
| {{- end }} | |||
| {{- if eq .NodePool.ConfigItems.cpu_management_policy "static" }} | |||
There was a problem hiding this comment.
Are there more resonable options? If yes it would make sense to do:
{{- if ... }}
cpuManagerPolicy: {{ .NodePool.ConfigItems.cpu_management_policy }}
{{- end }}
There was a problem hiding this comment.
Or even drop the if if you have a default.
There was a problem hiding this comment.
There's only none and static, but it might make sense to just drop the if since we are going to roll the nodes for v1.14 anyway, so the if doesn't provide so much in this case :)
There was a problem hiding this comment.
I have dropped the if and used the same keyword everywhere.
arjunrn
force-pushed
the
static-cpu-manager
branch
from
9e7a63c to
5e1a63b
Compare
Signed-off-by: Arjun Naik <[email protected]>
arjunrn
force-pushed
the
static-cpu-manager
branch
from
5e1a63b to
9fd5a1a
Compare
|
👍 |
1 similar comment
|
👍 |
The
staticCPU management policies allow entire CPUs to be allocated to pods which might be useful for workloads which benefit from CPU affinity. Thestaticpolicy is only enabled when the config item is present and static to the valuestatic.