Make test fails due to keeping github.com autogenerated folder in root #1713
Conversation
dmvolod
requested review from
CyberDem0n,
erthalion,
FxKu,
Jan-M and
sdudoladov
as code owners
| @@ -1,3 +1,4 @@ | |||
| //go:build !ignore_autogenerated | |||
There was a problem hiding this comment.
I think, this line can be removed. When I run make codegen in this branch, I don't get this line.
There was a problem hiding this comment.
@FxKu seem to this line depends of the golang version utilizing. Before adding this line, CI job has failed without it.
There was a problem hiding this comment.
Also saw these changes in several PRs
There was a problem hiding this comment.
Which CI job? Do have links to "other PRs"?
There was a problem hiding this comment.
There was a problem hiding this comment.
I see, hmm:
diffing hack/../pkg against freshly generated codegen
diff -Naupr hack/../pkg/apis/acid.zalan.do/v1/zz_generated.deepcopy.go hack/../_tmp/pkg/apis/acid.zalan.do/v1/zz_generated.deepcopy.go
--- hack/../pkg/apis/acid.zalan.do/v1/zz_generated.deepcopy.go 2021-12-02 07:21:30.048366700 +0000
+++ hack/../_tmp/pkg/apis/acid.zalan.do/v1/zz_generated.deepcopy.go 2021-12-02 07:24:23.029626056 +0000
@@ -1,3 +1,4 @@
+//go:build !ignore_autogenerated
// +build !ignore_autogenerated
/*
hack/../pkg is out of date. Please run 'make codegen'
make: *** [Makefile:103: test] Error 1
Error: Process completed with exit code 2.
There was a problem hiding this comment.
on my machine it's the opposite. When I add this line verify-codegen fails. Maybe should update to Go 1.17 (using 1.16.0 currently).
EDIT: Upgraded to 1.17.4 locally. Now, it's the same for me like for you.
There was a problem hiding this comment.
Yes, indeed, but confusing a bit with CI is utilizing golang version 1.16.9
There was a problem hiding this comment.
Can you bring back the generated code line we talked about? Then this PR can be merged.
|
Awesome @dmvolod ! Thanks a lot 😃 |
|
👍 |
1 similar comment
|
👍 |
fixes #1707
Also codegeneration scripts a bit refactored. Added
make codegentarget. NowRun unit testsin GitHub actions utilizingmake testtarget.