Replace murmur3 with xxhash for hashing

Signed-off-by: Remy Chantenay <[email protected]>

filters/accesslog/control.go

@@ -105,7 +105,7 @@ func NewMaskAccessLogQuery() filters.Spec {
 func (*maskAccessLogQuery) Name() string { return filters.MaskAccessLogQueryName }
 
 func (al *maskAccessLogQuery) CreateFilter(args []interface{}) (filters.Filter, error) {
-	if len(args) <= 0 {
+	if len(args) == 0 {
 		return nil, filters.ErrInvalidFilterParameters
 	}
 

go.mod

@@ -37,7 +37,6 @@ require (
 	github.com/sarslanhan/cronmask v0.0.0-20230801193303-54e29300a091
 	github.com/sirupsen/logrus v1.9.3
 	github.com/sony/gobreaker v0.5.0
-	github.com/spaolacci/murmur3 v1.1.0
 	github.com/stretchr/testify v1.8.4
 	github.com/szuecs/rate-limit-buffer v0.9.0
 	github.com/testcontainers/testcontainers-go v0.25.0

logging/access.go

@@ -4,11 +4,12 @@ import (
 	"fmt"
 	"net"
 	"net/http"
+	"strconv"
 	"strings"
 	"time"
 
+	"github.com/cespare/xxhash/v2"
 	"github.com/sirupsen/logrus"
-	"github.com/spaolacci/murmur3"
 
 	flowidFilter "github.com/zalando/skipper/filters/flowid"
 	logFilter "github.com/zalando/skipper/filters/log"
@@ -22,9 +23,6 @@ const (
 	combinedLogFormat = commonLogFormat + ` "%s" "%s"`
 	// We add the duration in ms, a requested host and a flow id and audit log
 	accessLogFormat = combinedLogFormat + " %d %s %s %s\n"
-
-	// seedQueryParamMaskingHash represents the seed used to hash masked query parameters in access log.
-	seedQueryParamMaskingHash = 42
 )
 
 type accessLogFormatter struct {
@@ -113,14 +111,8 @@ func stripQueryString(u string) string {
 	}
 }
 
-// seedQueryParamMaskingHash hashes a provided query parameter value and returns the hashed value.
-// Uses the murmur3 algorithm and a 32-bit hasher set.
-func hashQueryParamValue(val string) string {
-	h32 := murmur3.New32WithSeed(seedQueryParamMaskingHash)
-	h32.Write([]byte(val))
-	hashedVal := h32.Sum32()
-
-	return fmt.Sprint(hashedVal)
+func hash(val string) uint64 {
+	return xxhash.Sum64String(val)
 }
 
 // Logs an access event in Apache combined log format (with a minor customization with the duration).
@@ -168,7 +160,8 @@ func LogAccess(entry *AccessEntry, additional map[string]interface{}, maskedQuer
 					continue
 				}
 
-				params.Set(maskedQueryParams[i], hashQueryParamValue(val))
+				hashed := hash(val)
+				params.Set(maskedQueryParams[i], strconv.Itoa(int(hashed)))
 			}
 
 			uri = fmt.Sprintf("%s?%s", strippedURI, params.Encode())