optimize east-west routes creation #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandor Szücs <[email protected]>
Signed-off-by: Sandor Szücs <[email protected]>
Signed-off-by: Sandor Szücs <[email protected]>
…west routes Signed-off-by: Sandor Szücs <[email protected]>
aryszka
reviewed
Dec 8, 2020
dataclients/kubernetes/ingress.go
Outdated
| @@ -318,17 +318,23 @@ func (ing *ingress) addEndpointsRule(ic ingressContext, host string, prule *defi | |||
| redirect.setHostDisabled(host) | |||
| } | |||
|
|
|||
| if ing.kubernetesEnableEastWest { | |||
| ewRoute := createEastWestRouteIng(ing.eastWestDomainRegexpPostfix, ic.ingress.Metadata.Name, ic.ingress.Metadata.Namespace, endpointsRoute) | |||
| ic.addHostRoute(ewRoute.HostRegexps[0], ewRoute) | |||
Signed-off-by: Sandor Szücs <[email protected]>
Signed-off-by: Sandor Szücs <[email protected]>
Signed-off-by: Sandor Szücs <[email protected]>
|
👍 |
1 similar comment
|
👍 |
|
errors in the pipeline are only caused by zappr change and the PR is older than the merged one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sandor Szücs [email protected]