Do not use endpointregistry in the hotpath #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The performance of endpointregistry under circumstances of high concurenncy is the very discussable topic, it does not seem to work perfectly at the moment. Signed-off-by: Roman Zavodskikh <[email protected]>
|
👍 |
2 similar comments
|
👍 |
|
👍 |
pull bot
pushed a commit
to kokizzu/skipper
that referenced
this pull request
Oct 12, 2023
The performance of endpointregistry under circumstances of high concurenncy is the very discussable topic, it does not seem to work perfectly at the moment. Signed-off-by: Roman Zavodskikh <[email protected]> Co-authored-by: Roman Zavodskikh <[email protected]>
|
Could you also reference the commit & version that introduced the problematic change? |
RomanZavodskikh
pushed a commit
that referenced
this pull request
Nov 30, 2023
This reverts commit 9de6be2.
RomanZavodskikh
pushed a commit
that referenced
this pull request
Dec 4, 2023
This reverts commit 9de6be2. Signed-off-by: Roman Zavodskikh <[email protected]>
RomanZavodskikh
pushed a commit
that referenced
this pull request
Dec 4, 2023
This reverts commit 9de6be2. Signed-off-by: Roman Zavodskikh <[email protected]>
RomanZavodskikh
pushed a commit
that referenced
this pull request
Dec 4, 2023
This reverts commit 9de6be2. Signed-off-by: Roman Zavodskikh <[email protected]>
RomanZavodskikh
pushed a commit
that referenced
this pull request
Dec 5, 2023
This reverts commit 9de6be2. Signed-off-by: Roman Zavodskikh <[email protected]>
RomanZavodskikh
pushed a commit
that referenced
this pull request
Dec 5, 2023
This reverts commit 9de6be2. Signed-off-by: Roman Zavodskikh <[email protected]>
RomanZavodskikh
pushed a commit
that referenced
this pull request
Dec 6, 2023
This reverts commit 9de6be2. Signed-off-by: Roman Zavodskikh <[email protected]>
RomanZavodskikh
pushed a commit
that referenced
this pull request
Dec 6, 2023
This reverts commit 9de6be2. Signed-off-by: Roman Zavodskikh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance of endpointregistry under circumstances of high concurenncy is the very discussable topic, it does not seem to work perfectly at the moment.