Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation webhook: Initialize validator object in tests #2690

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

MustafaSaber
Copy link
Member

@MustafaSaber MustafaSaber commented Oct 18, 2023

Test shouldn't be working without validator initialized or at least some of them, related to #1618.

Signed-off-by: Mustafa Abdelrahman <[email protected]>
@szuecs
Copy link
Member

szuecs commented Oct 30, 2023

👍

1 similar comment
@MustafaSaber
Copy link
Member Author

👍

@MustafaSaber MustafaSaber merged commit ebd4f9d into cw2023freeze Nov 1, 2023
4 checks passed
@MustafaSaber MustafaSaber deleted the fix-validation-test branch November 1, 2023 13:50
szuecs pushed a commit that referenced this pull request Nov 7, 2023
RomanZavodskikh pushed a commit that referenced this pull request Nov 27, 2023
Signed-off-by: Mustafa Abdelrahman <[email protected]>
RomanZavodskikh pushed a commit that referenced this pull request Nov 27, 2023
Signed-off-by: Mustafa Abdelrahman <[email protected]>
AlexanderYastrebov pushed a commit that referenced this pull request Nov 27, 2023
AlexanderYastrebov pushed a commit that referenced this pull request Nov 27, 2023
@MustafaSaber MustafaSaber self-assigned this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants