routing: avoid allocating new entry in EndpointRegistry.GetMetrics #2847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EndpointRegistry.GetMetrics always allocates new entry even when data for the key already exists. sync.Map does not provide lazy initialization for the new value, see golang/go#44159 This change uses suggested best-effort to avoid allocating a new value on each load. Follow up on #2795 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
routing/avoid-entry-alloc
branch
from
1c5d7c0 to
e0ec88e
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EndpointRegistry.GetMetrics always allocates new entry even when data for the key already exists.
sync.Map does not provide lazy initialization for the new value, see golang/go#44159
This change uses suggested best-effort to avoid allocating a new value on each load.
Follow up on #2795