[WIP] Refactoring #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to add the ability to save, share and get logs/reports. However, before we'll be able to implement that, the app needs a complete refactoring.
Even though this app is intended for debugging Redux apps, it doesn't use Redux. Keeping the functionality in independent React components gives us the ability to import only several functionality from here. But it's hard to debug and extend the app. I'm working on making this app predictable, so at some point we'll be able to debug Redux DevTools Extension with Redux DevTools Extension.
My concern is not to break
react-native-debuggerandremote-redux-devtools-on-debugger.It will be still possible to use only specific functionality by importing also reducers along with the components, but better we add props to customize the app instead. So vendor apps maintainers can just update the lib instead of adding the changes manually.
Anyway, I'll add an example on how to include just a specific functionality to make the integration easier.
/cc @jhen0409