Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct paremeters and directories when calling keygen #26

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

dd23
Copy link
Member

@dd23 dd23 commented Aug 5, 2024

Fixed an issue with outdated CLI agruments when calling kms core keygen.

Also updates a few minor things in the README.

@cla-bot cla-bot bot added the cla-signed label Aug 5, 2024
@dd23 dd23 requested review from fd0r and jot2re August 5, 2024 12:58
Copy link
Contributor

@fd0r fd0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

With KEY_GEN=true in .env the tests are now passing.

Copy link

cla-bot bot commented Aug 5, 2024

Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @jot2re on file. In order for us to review and merge your code, please sign:

  • For individual contribution: our CLA
  • for Bounty submission, if you are an individual: our T&C
  • for Bounty submission, if you are a company: our T&C
    to get yourself added.

If you already signed one of this document, just wait to be added to the bot config.

@cla-bot cla-bot bot removed the cla-signed label Aug 5, 2024
Copy link

cla-bot bot commented Aug 5, 2024

Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @jot2re on file. In order for us to review and merge your code, please sign:

  • For individual contribution: our CLA
  • for Bounty submission, if you are an individual: our T&C
  • for Bounty submission, if you are a company: our T&C
    to get yourself added.

If you already signed one of this document, just wait to be added to the bot config.

Copy link
Contributor

@jot2re jot2re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! But I didn't test yet.
I found a missing update to a comment which I added. I also added a couple of updates to the readme file

Copy link

cla-bot bot commented Aug 5, 2024

Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @jot2re on file. In order for us to review and merge your code, please sign:

  • For individual contribution: our CLA
  • for Bounty submission, if you are an individual: our T&C
  • for Bounty submission, if you are a company: our T&C
    to get yourself added.

If you already signed one of this document, just wait to be added to the bot config.

@dd23 dd23 force-pushed the dd/fix/keygen_params branch from 7ecbb9b to 46c82d0 Compare August 5, 2024 14:51
@cla-bot cla-bot bot added the cla-signed label Aug 5, 2024
@dd23 dd23 merged commit a65a704 into main Aug 5, 2024
1 check passed
@aquint-zama
Copy link

@cla-bot check

Copy link

cla-bot bot commented Aug 8, 2024

The cla-bot has been summoned, and re-checked this pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants