-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct paremeters and directories when calling keygen #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
With KEY_GEN=true
in .env
the tests are now passing.
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @jot2re on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @jot2re on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! But I didn't test yet.
I found a missing update to a comment which I added. I also added a couple of updates to the readme file
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @jot2re on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
7ecbb9b
to
46c82d0
Compare
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
Fixed an issue with outdated CLI agruments when calling kms core keygen.
Also updates a few minor things in the README.