cleanup container volume names, delete unused items #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
manoranjith
commented
Dec 10, 2024
manoranjith
commented
- chore: remove unused scripts and asc directory
- chore: override project, network name for compose
- chore: cleanup fhevm, copro related names
- chore: cleanup kms related names
- chore: explicit container names to avoid -1 suffix
- chore: remove completed TODOs
- use "fhevm-" prefix consistently for all components. - use "setup-" for setup related components.
- use no prefix for gateway as it connects fhevm and kms parts. - use "kms-" prefix consistently for all kms components. - use "setup-" for setup related components.
|
I have created another PR based on this one with minor improvements. Let's merge it before : #70 |
chore: clean a bit more some files, update docker service names everywhere, …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.